Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: build/common.gypi

Issue 1555893002: Linux/CrOS/Cast/Android (and Mac with gn): Build 3rd-party code with -Wall. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3122 matching lines...) Expand 10 before | Expand all | Expand 10 after
3133 ['chromium_code==0', { 3133 ['chromium_code==0', {
3134 'variables': { 3134 'variables': {
3135 'clang_warning_flags': [ 3135 'clang_warning_flags': [
3136 # Lots of third-party libraries have unused variables. Instead of 3136 # Lots of third-party libraries have unused variables. Instead of
3137 # suppressing them individually, we just blanket suppress them here. 3137 # suppressing them individually, we just blanket suppress them here.
3138 '-Wno-unused-variable', 3138 '-Wno-unused-variable',
3139 ], 3139 ],
3140 }, 3140 },
3141 'conditions': [ 3141 'conditions': [
3142 [ 'os_posix==1 and OS!="mac" and OS!="ios"', { 3142 [ 'os_posix==1 and OS!="mac" and OS!="ios"', {
3143 # We don't want to get warnings from third-party code, 3143 # Remove -Wextra for third-party code.
3144 # so remove any existing warning-enabling flags like -Wall. 3144 'cflags!': [ '-Wextra' ],
3145 'cflags!': [
3146 '-Wall',
3147 '-Wextra',
3148 ],
3149 'cflags_cc': [ 3145 'cflags_cc': [
3150 # Don't warn about hash_map in third-party code. 3146 # Don't warn about hash_map in third-party code.
3151 '-Wno-deprecated', 3147 '-Wno-deprecated',
3152 ], 3148 ],
3153 'cflags': [ 3149 'cflags': [
3154 # Don't warn about printf format problems. 3150 # Don't warn about printf format problems.
3155 # This is off by default in gcc but on in Ubuntu's gcc(!). 3151 # This is off by default in gcc but on in Ubuntu's gcc(!).
3156 '-Wno-format', 3152 '-Wno-format',
3157 ], 3153 ],
3158 }], 3154 }],
3155 [ 'os_posix==1 and clang!=1 and OS!="mac" and OS!="ios"', {
3156 # When we don't control the compiler, don't use -Wall for
3157 # third-party code either.
3158 'cflags!': [ '-Wall' ],
3159 }],
3159 # TODO: Fix all warnings on chromeos too. 3160 # TODO: Fix all warnings on chromeos too.
3160 [ 'os_posix==1 and OS!="mac" and OS!="ios" and (clang!=1 or chromeos== 1)', { 3161 [ 'os_posix==1 and OS!="mac" and OS!="ios" and (clang!=1 or chromeos== 1)', {
3161 'cflags!': [ 3162 'cflags!': [
3162 '-Werror', 3163 '-Werror',
3163 ], 3164 ],
3164 }], 3165 }],
3165 [ 'os_posix==1 and os_bsd!=1 and OS!="mac" and OS!="android"', { 3166 [ 'os_posix==1 and os_bsd!=1 and OS!="mac" and OS!="android"', {
3166 'cflags': [ 3167 'cflags': [
3167 # Don't warn about ignoring the return value from e.g. close(). 3168 # Don't warn about ignoring the return value from e.g. close().
3168 # This is off by default in some gccs but on by default in others. 3169 # This is off by default in some gccs but on by default in others.
(...skipping 3253 matching lines...) Expand 10 before | Expand all | Expand 10 after
6422 # settings in target dicts. SYMROOT is a special case, because many other 6423 # settings in target dicts. SYMROOT is a special case, because many other
6423 # Xcode variables depend on it, including variables such as 6424 # Xcode variables depend on it, including variables such as
6424 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6425 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6425 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6426 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6426 # files to appear (when present) in the UI as actual files and not red 6427 # files to appear (when present) in the UI as actual files and not red
6427 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6428 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6428 # and therefore SYMROOT, needs to be set at the project level. 6429 # and therefore SYMROOT, needs to be set at the project level.
6429 'SYMROOT': '<(DEPTH)/xcodebuild', 6430 'SYMROOT': '<(DEPTH)/xcodebuild',
6430 }, 6431 },
6431 } 6432 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698