Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1555833002: Reapply "Fix a partial rendering problem" (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
jun_fang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply "Fix a partial rendering problem" This reverts commit 054fc955c153eb5c581fd14946848b8b2a77136a. Additionally, this rolls DEPS for the testing corpus to update test expectations. BUG=pdfium:336 TBR=jun_fang@foxitsoftware.com Original Review URL: https://codereview.chromium.org/1555773003 Committed: https://pdfium.googlesource.com/pdfium/+/5594538fcc96c38db34f336223140cf703e3cca0

Patch Set 1 #

Patch Set 2 : Roll DEPS as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M samples/pdfium_test.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M testing/embedder_test.cpp View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
Hope the tests are happy.
4 years, 11 months ago (2015-12-31 21:07:06 UTC) #1
Lei Zhang
Committed patchset #2 (id:20001) manually as 5594538fcc96c38db34f336223140cf703e3cca0 (presubmit successful).
4 years, 11 months ago (2015-12-31 21:07:26 UTC) #3
jun_fang
4 years, 11 months ago (2016-01-01 01:30:52 UTC) #4
Message was sent while issue was closed. 
On 2015/12/31 21:07:26, Lei Zhang wrote:
> Committed patchset #2 (id:20001) manually as
> 5594538fcc96c38db34f336223140cf703e3cca0 (presubmit successful).

LGTM

Powered by Google App Engine
This is Rietveld 408576698