Fix a partial rendering problem

Fix a partial rendering problem

BUG=pdfium:336
R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/84f6a5616be0a1988d361a4b54eb83fff8b8c59f

[jun_fang, 2015-12-31 08:08:19]

jun_fang@foxitsoftware.com changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[jun_fang, 2015-12-31 08:08:19]

Hi Tom and Lei,

Please help to review this CL. Thanks!

[jun_fang, 2015-12-31 08:15:21]

On 2015/12/31 08:08:19, jun_fang wrote:
> Hi Tom and Lei,
> 
> Please help to review this CL. Thanks!

This issue reproduced in chromium side. Please do the similar change on
chromium.

[Lei Zhang, 2015-12-31 09:27:45]

lgtm

Can you make a similar change to testing/embedder_test.cpp? I'll take care of
the Chromium side.

https://codereview.chromium.org/1555773003/diff/1/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/1555773003/diff/1/samples/pdfium_test.cc#newc...
samples/pdfium_test.cc:360: FPDF_DWORD fill_color = alpha ? 0 : 0xFFFFFFFF;
Can the "0" be "0x00000000" instead?

[jun_fang, 2015-12-31 09:40:07]

Hi Lei,

Please take a look at patch 2.

https://codereview.chromium.org/1555773003/diff/1/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/1555773003/diff/1/samples/pdfium_test.cc#newc...
samples/pdfium_test.cc:360: FPDF_DWORD fill_color = alpha ? 0 : 0xFFFFFFFF;
On 2015/12/31 09:27:45, Lei Zhang wrote:
> Can the "0" be "0x00000000" instead?

Acknowledged.

[Lei Zhang, 2015-12-31 09:59:21]

++lgtm

[jun_fang, 2015-12-31 14:33:49]

Description was changed from

==========
Fix a partial rendering problem

BUG=pdfium:336
==========

to

==========
Fix a partial rendering problem

BUG=pdfium:336
R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/84f6a5616be0a1988d361a4b54eb83fff8b8...
==========

[jun_fang, 2015-12-31 14:33:53]

Committed patchset #2 (id:20001) manually as
84f6a5616be0a1988d361a4b54eb83fff8b8c59f (presubmit successful).