Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Issue 1555543002: Revert of WebGL 2: generate appropriate error for different dimensions of images attached to fbo (Closed)

Created:
4 years, 11 months ago by Geoff Lang
Modified:
4 years, 11 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of WebGL 2: generate appropriate error for different dimensions of images attached to fbo (patchset #1 id:1 of https://codereview.chromium.org/1549393002/ ) Reason for revert: This broke the WebglConformance.conformance2_rendering_draw_buffers test on mac. Original issue's description: > WebGL 2: generate appropriate error for different dimensions of images attached to fbo. > This change fixed the bug in framebuffer-object-attachment.html > > BUG=295792 > TEST=conformance2/renderbuffers/framebuffer-object-attachment.html > > Committed: https://crrev.com/23cf53ece33a651b28a1d87e57f02a14f22d3c3d > Cr-Commit-Position: refs/heads/master@{#367053} TBR=kbr@chromium.org,zmo@chromium.org,bajones@chromium.org,qiankun.miao@intel.com,yunchao.he@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=295792 Committed: https://crrev.com/02edc79d6c10a23b1521f773629539c7b139ceb2 Cr-Commit-Position: refs/heads/master@{#367070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -26 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp View 6 chunks +10 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Geoff Lang
Created Revert of WebGL 2: generate appropriate error for different dimensions of images attached to ...
4 years, 11 months ago (2015-12-29 14:45:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555543002/1
4 years, 11 months ago (2015-12-29 14:46:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-29 14:46:36 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 14:47:19 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02edc79d6c10a23b1521f773629539c7b139ceb2
Cr-Commit-Position: refs/heads/master@{#367070}

Powered by Google App Engine
This is Rietveld 408576698