Issue 1555413002: [ios] Make sure that |didFinishNavigation| is signalled for fast goBack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1555413002: [ios] Make sure that |didFinishNavigation| is signalled for fast goBack. (Closed)

Created:
4 years, 11 months ago by Eugene But (OOO till 7-30)

Modified:
4 years, 11 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

[ios] Make sure that |didFinishNavigation| is signalled for fast goBack. A fast back/forward may not call |webView:didFinishNavigation:|, so finishing the navigation should be signalled explicitely when WKWebView isLoading is changed to NO. BUG=571584 Review URL: https://codereview.chromium.org/1546603005 Cr-Commit-Position: refs/heads/master@{#367390} (cherry picked from commit 7ce600bd5b62b2c79b288a5bf493251b8e8aa59a) Committed: https://chromium.googlesource.com/chromium/src/+/d4345ac53a6f2f3abc78fd3a38042c160da0b38a

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	ios/web/web_state/ui/crw_wk_web_view_web_controller.mm	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Eugene But (OOO till 7-30)

4 years, 11 months ago (2016-01-05 19:19:52 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d4345ac53a6f2f3abc78fd3a38042c160da0b38a.