Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: ios/web/web_state/ui/crw_wk_web_view_web_controller.mm

Issue 1555413002: [ios] Make sure that |didFinishNavigation| is signalled for fast goBack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2564
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_wk_web_view_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm b/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm
index f25c671a3a249884747f31e4ecb2b061defc5fe1..5559c5ba05508b4fe91411dab26d3f802b980410 100644
--- a/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm
+++ b/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm
@@ -1654,6 +1654,12 @@ WKWebViewErrorSource WKWebViewErrorSourceFromError(NSError* error) {
[self addActivityIndicatorTask];
} else {
[self clearActivityIndicatorTasks];
+ if ([self currentBackForwardListItemHolder]->navigation_type() ==
+ WKNavigationTypeBackForward) {
+ // A fast back/forward may not call |webView:didFinishNavigation:|, so
+ // finishing the navigation should be signalled explicitly.
+ [self didFinishNavigation];
+ }
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698