Instant Extended: Reduce clipping in omnibox

chrome/browser/ui/cocoa/styled_text_field_cell.mm

Index: chrome/browser/ui/cocoa/styled_text_field_cell.mm
diff --git a/chrome/browser/ui/cocoa/styled_text_field_cell.mm b/chrome/browser/ui/cocoa/styled_text_field_cell.mm
index 4cf3f707e81e61e3b938433e59896fab0b19da8c..c894ad5c132a74ca3f0d551bb38f8af5b023a72a 100644
--- a/chrome/browser/ui/cocoa/styled_text_field_cell.mm
+++ b/chrome/browser/ui/cocoa/styled_text_field_cell.mm
@@ -35,13 +35,13 @@
 // Returns the same value as textCursorFrameForFrame, but does not call it
 // directly to avoid potential infinite loops.
 - (NSRect)textFrameForFrame:(NSRect)cellFrame {
-  return NSInsetRect(cellFrame, 0, [self baselineAdjust]);
+  return NSIntegralRect(NSInsetRect(cellFrame, 0, [self baselineAdjust]));

[Scott Hess - ex-Googler, 2013/05/22 19:56:37]

Does this imply that cellFrame has fractional bits?  Because otherwise it's just
going to give the same rect as the previous integral value for baselineAdjust
would have given.

[sail, 2013/05/22 20:23:55]

Yes, this will be fractional since it's being inset by 2.5.

[Scott Hess - ex-Googler, 2013/05/22 21:02:36]

The NSIntegralRect() means that this will be pushed out to be integral, and the
baseline doesn't go to a half-pixel, so ... this seems very mis-leading.

If we need to have separate hard-coded adjustments for height and offset, fine,
but having everything driven by a "baseline" adjustment which adjusts different
things differently seems poor.

 }
 
 // Returns the same value as textFrameForFrame, but does not call it directly to
 // avoid potential infinite loops.
 - (NSRect)textCursorFrameForFrame:(NSRect)cellFrame {
-  return NSInsetRect(cellFrame, 0, [self baselineAdjust]);
+  return NSIntegralRect(NSInsetRect(cellFrame, 0, [self baselineAdjust]));
 }
 
 // Override to show the I-beam cursor only in the area given by