Instant Extended: Reduce clipping in omnibox

chrome/browser/ui/cocoa/styled_text_field_cell.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/styled_text_field_cell.h"
 
 #include "base/logging.h"
 #include "chrome/browser/themes/theme_properties.h"
 #include "chrome/browser/themes/theme_service.h"
 #import "chrome/browser/ui/cocoa/nsview_additions.h"
@@ skipping 17 matching lines @@
   return rect_path_utils::RoundedCornerAll;
 }
 
 - (BOOL)shouldDrawBezel {
   return NO;
 }
 
 // Returns the same value as textCursorFrameForFrame, but does not call it
 // directly to avoid potential infinite loops.
 - (NSRect)textFrameForFrame:(NSRect)cellFrame {
-  return NSInsetRect(cellFrame, 0, [self baselineAdjust]);
+  return NSIntegralRect(NSInsetRect(cellFrame, 0, [self baselineAdjust]));

[Scott Hess - ex-Googler, 2013/05/22 19:56:37]

Does this imply that cellFrame has fractional bits?  Because otherwise it's just
going to give the same rect as the previous integral value for baselineAdjust
would have given.

[sail, 2013/05/22 20:23:55]

Yes, this will be fractional since it's being inset by 2.5.

[Scott Hess - ex-Googler, 2013/05/22 21:02:36]

The NSIntegralRect() means that this will be pushed out to be integral, and the
baseline doesn't go to a half-pixel, so ... this seems very mis-leading.

If we need to have separate hard-coded adjustments for height and offset, fine,
but having everything driven by a "baseline" adjustment which adjusts different
things differently seems poor.

 }
 
 // Returns the same value as textFrameForFrame, but does not call it directly to
 // avoid potential infinite loops.
 - (NSRect)textCursorFrameForFrame:(NSRect)cellFrame {
-  return NSInsetRect(cellFrame, 0, [self baselineAdjust]);
+  return NSIntegralRect(NSInsetRect(cellFrame, 0, [self baselineAdjust]));
 }
 
 // Override to show the I-beam cursor only in the area given by
 // |textCursorFrameForFrame:|.
 - (void)resetCursorRect:(NSRect)cellFrame inView:(NSView *)controlView {
   [super resetCursorRect:[self textCursorFrameForFrame:cellFrame]
                   inView:controlView];
 }
 
 // For NSTextFieldCell this is the area within the borders.  For our
@@ skipping 96 matching lines @@
   // Draw the focus ring if needed.
   if ([self showsFirstResponder]) {
     NSColor* color = [[NSColor keyboardFocusIndicatorColor]
         colorWithAlphaComponent:0.5 / lineWidth];
     rect_path_utils::FrameRectWithInset(roundedCornerFlags, frame, 0.0, 0.0,
                                         radius, lineWidth * 2, color);
   }
 }
 
 @end