Add skstd::remove_pointer_t and use it.

Add skstd::remove_pointer_t and use it.

This replaces an existing incomplete implementation. This also makes
it easier to update the current use in the future when switching to
<type_traits>.

Committed: https://skia.googlesource.com/skia/+/54e63082191f337084f96083ca90d7c35273d6ff

[bungeman-skia, 2016-01-04 21:40:21]

Description was changed from

==========
Add skstd::remove_pointer_t and use it.

This replaces an existing incomplete implementation. This also makes
it easier to update the current use in the future when switching to
<type_traits>.
==========

to

==========
Add skstd::remove_pointer_t and use it.

This replaces an existing incomplete implementation. This also makes
it easier to update the current use in the future when switching to
<type_traits>.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-01-04 21:41:21]

Description was changed from

==========
Add skstd::remove_pointer_t and use it.

This replaces an existing incomplete implementation. This also makes
it easier to update the current use in the future when switching to
<type_traits>.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add skstd::remove_pointer_t and use it.

This replaces an existing incomplete implementation. This also makes
it easier to update the current use in the future when switching to
<type_traits>.
==========

[bungeman-skia, 2016-01-04 21:43:47]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-04 21:43:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1555153002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1555153002/1

[bungeman-skia, 2016-01-04 21:53:13]

bungeman@google.com changed reviewers:
+ djsollen@google.com

[bungeman-skia, 2016-01-04 21:53:14]

I originally wrote the incomplete version because I needed the underlying type
of a pointer typedef (and the underlying type name isn't documented and has
changed in the past). By making this more complete and standard-ish it will be
easier to update when we move to type_traits.

[commit-bot: I haz the power, 2016-01-04 21:59:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-04 21:59:56]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-01-04 22:38:22]

bungeman@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-01-05 02:41:00]

https://codereview.chromium.org/1555153002/diff/1/include/private/SkTLogic.h
File include/private/SkTLogic.h (right):

https://codereview.chromium.org/1555153002/diff/1/include/private/SkTLogic.h#...
include/private/SkTLogic.h:62: template <typename T, typename T_cv> struct
remove_pointer_no_cv { using type = T; };
Can't we use std::remove_ptr, then build skstd::remove_ptr_t on top?

[bungeman-skia, 2016-01-06 16:07:44]

Description was changed from

==========
Add skstd::remove_pointer_t and use it.

This replaces an existing incomplete implementation. This also makes
it easier to update the current use in the future when switching to
<type_traits>.
==========

to

==========
Add skstd::remove_pointer_t and use it.

This replaces an existing incomplete implementation. This also makes
it easier to update the current use in the future when switching to
<type_traits>.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-01-06 16:07:57]

Description was changed from

==========
Add skstd::remove_pointer_t and use it.

This replaces an existing incomplete implementation. This also makes
it easier to update the current use in the future when switching to
<type_traits>.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add skstd::remove_pointer_t and use it.

This replaces an existing incomplete implementation. This also makes
it easier to update the current use in the future when switching to
<type_traits>.
==========

[bungeman-skia, 2016-01-06 16:08:14]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-06 16:08:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1555153002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1555153002/20001

[bungeman-skia, 2016-01-06 16:25:16]

https://codereview.chromium.org/1555153002/diff/1/include/private/SkTLogic.h
File include/private/SkTLogic.h (right):

https://codereview.chromium.org/1555153002/diff/1/include/private/SkTLogic.h#...
include/private/SkTLogic.h:62: template <typename T, typename T_cv> struct
remove_pointer_no_cv { using type = T; };
On 2016/01/05 02:41:00, mtklein wrote:
> Can't we use std::remove_pointer, then build skstd::remove_pointer_t on top?

Yes, but doing so would mean fixing all the other things in here for
consistency. Instead of doing that later, lets just do it now
https://codereview.chromium.org/1561683002/ .

So, done.

[commit-bot: I haz the power, 2016-01-06 16:25:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-06 16:25:28]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-01-06 16:26:57]

On 2016/01/06 16:25:16, bungeman1 wrote:
> https://codereview.chromium.org/1555153002/diff/1/include/private/SkTLogic.h
> File include/private/SkTLogic.h (right):
> 
>
https://codereview.chromium.org/1555153002/diff/1/include/private/SkTLogic.h#...
> include/private/SkTLogic.h:62: template <typename T, typename T_cv> struct
> remove_pointer_no_cv { using type = T; };
> On 2016/01/05 02:41:00, mtklein wrote:
> > Can't we use std::remove_pointer, then build skstd::remove_pointer_t on top?
> 
> Yes, but doing so would mean fixing all the other things in here for
> consistency. Instead of doing that later, lets just do it now
> https://codereview.chromium.org/1561683002/ .
> 
> So, done.

Are you explaining this to yesterday me?  :P

[mtklein, 2016-01-06 16:27:06]

lgtm

[bungeman-skia, 2016-01-06 16:29:35]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2016-01-06 16:29:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1555153002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1555153002/20001

[commit-bot: I haz the power, 2016-01-06 16:31:01]

Description was changed from

==========
Add skstd::remove_pointer_t and use it.

This replaces an existing incomplete implementation. This also makes
it easier to update the current use in the future when switching to
<type_traits>.
==========

to

==========
Add skstd::remove_pointer_t and use it.

This replaces an existing incomplete implementation. This also makes
it easier to update the current use in the future when switching to
<type_traits>.

Committed:
https://skia.googlesource.com/skia/+/54e63082191f337084f96083ca90d7c35273d6ff
==========

[commit-bot: I haz the power, 2016-01-06 16:31:02]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/54e63082191f337084f96083ca90d7c35273d6ff