Add skstd::remove_pointer_t and use it.

include/private/SkTLogic.h

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  *
  *
  * This header provides some of the helpers (std::integral_constant) and
  * type transformations (std::conditional) which will become available with
  * C++11 in the type_traits header.
@@ skipping 41 matching lines @@
 template <typename T> using remove_volatile_t = typename remove_volatile<T>::type;
 
 template <typename T> struct remove_cv { using type = remove_volatile_t<remove_const_t<T>>; };
 template <typename T> using remove_cv_t = typename remove_cv<T>::type;
 
 template <typename T> struct remove_reference { using type = T; };
 template <typename T> struct remove_reference<T&> { using type = T; };
 template <typename T> struct remove_reference<T&&> { using type = T; };
 template <typename T> using remove_reference_t = typename remove_reference<T>::type;
 
+template <typename T, typename T_cv> struct remove_pointer_no_cv { using type = T; };

[mtklein, 2016/01/05 02:41:00]

Can't we use std::remove_ptr, then build skstd::remove_ptr_t on top?

[bungeman-skia, 2016/01/06 16:25:16]

Yes, but doing so would mean fixing all the other things in here for
consistency. Instead of doing that later, lets just do it now
https://codereview.chromium.org/1561683002/ .

So, done.

+template <typename T, typename T_cv> struct remove_pointer_no_cv<T, T_cv*> { using type = T_cv; };
+template <typename T> struct remove_pointer : remove_pointer_no_cv<T, remove_cv_t<T>> {};
+template <typename T> using remove_pointer_t = typename remove_pointer<T>::type;
+
 template <typename T> struct remove_extent { using type = T; };
 template <typename T> struct remove_extent<T[]> { using type = T; };
 template <typename T, size_t N> struct remove_extent<T[N]> { using type = T;};
 template <typename T> using remove_extent_t = typename remove_extent<T>::type;
 
 template <typename T, typename U> struct is_same : false_type {};
 template <typename T> struct is_same<T, T> : true_type {};
 
 template <typename T> struct is_void : is_same<void, remove_cv_t<T>> {};
 
@@ skipping 36 matching lines @@
 template <typename T> struct is_empty : bool_constant<is_empty_detector<T>::value> {};
 
 template <typename T> struct is_array : false_type {};
 template <typename T> struct is_array<T[]> : true_type {};
 template <typename T, size_t N> struct is_array<T[N]> : true_type {};
 
 // template<typename R, typename... Args> struct is_function<
 //     R [calling-convention] (Args...[, ...]) [const] [volatile] [&|&&]> : true_type {};
 // The cv and ref-qualified versions are strange types we're currently avoiding, so not supported.
 // On all platforms, variadic functions only exist in the c calling convention.
-template <typename> struct is_function : false_type { };
+template <typename> struct is_function : false_type {};
 #if !defined(SK_BUILD_FOR_WIN)
 template <typename R, typename... Args> struct is_function<R(Args...)> : true_type {};
 #else
 #if defined(_M_IX86)
 template <typename R, typename... Args> struct is_function<R __cdecl (Args...)> : true_type {};
 template <typename R, typename... Args> struct is_function<R __stdcall (Args...)> : true_type {};
 template <typename R, typename... Args> struct is_function<R __fastcall (Args...)> : true_type {};
 #if SK_CPU_SSE_LEVEL >= SK_CPU_SSE_LEVEL_SSE2
 template <typename R, typename... Args> struct is_function<R __vectorcall (Args...)> : true_type {};
 #endif
@@ skipping 11 matching lines @@
 template <typename T> using add_volatile_t = typename add_volatile<T>::type;
 
 template <typename T> struct add_cv { using type = add_volatile_t<add_const_t<T>>; };
 template <typename T> using add_cv_t = typename add_cv<T>::type;
 
 template <typename T> struct add_pointer { using type = remove_reference_t<T>*; };
 template <typename T> using add_pointer_t = typename add_pointer<T>::type;
 
 template <typename T, bool=is_void<T>::value> struct add_lvalue_reference_init { using type = T; };
 template <typename T> struct add_lvalue_reference_init<T, false> { using type = T&; };
-template <typename T> struct add_lvalue_reference : add_lvalue_reference_init<T> { };
+template <typename T> struct add_lvalue_reference : add_lvalue_reference_init<T> {};
 template <typename T> using add_lvalue_reference_t = typename add_lvalue_reference<T>::type;
 
 template <typename T, bool=is_void<T>::value> struct add_rvalue_reference_init { using type = T; };
 template <typename T> struct add_rvalue_reference_init<T, false> { using type = T&&; };
 template <typename T> struct add_rvalue_reference : add_rvalue_reference_init<T> {};
 template <typename T> using add_rvalue_reference_t = typename add_rvalue_reference<T>::type;
 
 /* This is 'just' a forward declaration. */
 template <typename T> add_rvalue_reference_t<T> declval() /*noexcept*/;
 
 template <typename S, typename D, bool=is_void<S>::value||is_function<D>::value||is_array<D>::value>
 struct is_convertible_detector {
     static const/*expr*/ bool value = is_void<D>::value;
 };
 template <typename S, typename D> struct is_convertible_detector<S, D, false> {
     using yes_type = uint8_t;
     using no_type = uint16_t;
 
     template <typename To> static void param_convertable_to(To);
 
     template <typename From, typename To>
     static decltype(param_convertable_to<To>(declval<From>()), yes_type()) convertible(int);
 
     template <typename, typename> static no_type convertible(...);
 
     static const/*expr*/ bool value = sizeof(convertible<S, D>(0)) == sizeof(yes_type);
 };
 template<typename S, typename D> struct is_convertible
-    : bool_constant<is_convertible_detector<S, D>::value> { };
+    : bool_constant<is_convertible_detector<S, D>::value> {};
 
 template <typename T> struct decay {
     using U = remove_reference_t<T>;
     using type = conditional_t<is_array<U>::value,
         remove_extent_t<U>*,
         conditional_t<is_function<U>::value, add_pointer_t<U>, remove_cv_t<U>>>;
 };
 template <typename T> using decay_t = typename decay<T>::type;
 
 }  // namespace skstd
@@ skipping 29 matching lines @@
 template <typename D, typename S> using same_volatile_t = typename same_volatile<D, S>::type;
 template <typename D, typename S> using same_cv = copy_cv<skstd::remove_cv_t<D>, S>;
 template <typename D, typename S> using same_cv_t = typename same_cv<D, S>::type;
 
 }  // namespace sknonstd
 
 // Just a pithier wrapper for enable_if_t.
 #define SK_WHEN(condition, T) skstd::enable_if_t<!!(condition), T>
 
 #endif