[Interpreter] Adds support for wide variant of load/store lookup slots.

[Interpreter] Adds support for wide variant of load/store lookup slots.

Adds implementation and tests for wide variant of load/store lookup slots.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/a0a8b6064395928ff813a213a0e1a7a09aef9274
Cr-Commit-Position: refs/heads/master@{#33111}

[mythria, 2016-01-04 13:33:29]

mythria@chromium.org changed reviewers:
+ bmeurer@chromium.org, rmcilroy@chromium.org

[mythria, 2016-01-04 13:33:30]

Benedikt, could you please look at compiler changes.
Ross, could you please review my changes.

Thanks,
Mythri

[rmcilroy, 2016-01-04 15:22:32]

One test comment, but otherwise lgtm, thanks.

https://codereview.chromium.org/1555063002/diff/1/test/cctest/interpreter/tes...
File test/cctest/interpreter/test-bytecode-generator.cc (right):

https://codereview.chromium.org/1555063002/diff/1/test/cctest/interpreter/tes...
test/cctest/interpreter/test-bytecode-generator.cc:5868:
{function_body[0].c_str(),
I would prefer you just put the actual function code directly in here for each
test. There is no deduping of double values in the constant pool, so you can
just put the same heap number in a bunch of times to get the result you want,
i.e.: 
  REPEAT_256(SPACE, "var y = 2.3;")
  "return x;"

[rmcilroy, 2016-01-04 15:22:35]

One test comment, but otherwise lgtm, thanks.

[Benedikt Meurer, 2016-01-05 05:07:39]

LGTM on compiler.

[mythria, 2016-01-05 10:07:26]

I fixed the tests.

Thanks,
Mythri

https://codereview.chromium.org/1555063002/diff/1/test/cctest/interpreter/tes...
File test/cctest/interpreter/test-bytecode-generator.cc (right):

https://codereview.chromium.org/1555063002/diff/1/test/cctest/interpreter/tes...
test/cctest/interpreter/test-bytecode-generator.cc:5868:
{function_body[0].c_str(),
On 2016/01/04 15:22:32, rmcilroy wrote:
> I would prefer you just put the actual function code directly in here for each
> test. There is no deduping of double values in the constant pool, so you can
> just put the same heap number in a bunch of times to get the result you want,
> i.e.: 
>   REPEAT_256(SPACE, "var y = 2.3;")
>   "return x;"
> 
Thanks,
Done.

[rmcilroy, 2016-01-05 10:19:32]

Still LGTM, thanks.

[mythria, 2016-01-05 11:21:13]

The CQ bit was checked by mythria@chromium.org

[mythria, 2016-01-05 11:21:13]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1555063002/#ps20001
(title: "Updated tests to address review comments.")

[commit-bot: I haz the power, 2016-01-05 11:21:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1555063002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1555063002/20001

[commit-bot: I haz the power, 2016-01-05 11:36:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-05 11:36:53]

Description was changed from

==========
[Interpreter] Adds support for wide variant of load/store lookup slots.

Adds implementation and tests for wide variant of load/store lookup slots.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Adds support for wide variant of load/store lookup slots.

Adds implementation and tests for wide variant of load/store lookup slots.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/a0a8b6064395928ff813a213a0e1a7a09aef9274
Cr-Commit-Position: refs/heads/master@{#33111}
==========

[commit-bot: I haz the power, 2016-01-05 11:36:53]

Patchset 2 (id:??) landed as
https://crrev.com/a0a8b6064395928ff813a213a0e1a7a09aef9274
Cr-Commit-Position: refs/heads/master@{#33111}