Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: test/unittests/interpreter/bytecode-array-builder-unittest.cc

Issue 1555063002: [Interpreter] Adds support for wide variant of load/store lookup slots. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Updated tests to address review comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/interpreter/test-interpreter.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/interpreter/bytecode-array-builder.h" 7 #include "src/interpreter/bytecode-array-builder.h"
8 #include "src/interpreter/bytecode-array-iterator.h" 8 #include "src/interpreter/bytecode-array-iterator.h"
9 #include "test/unittests/test-utils.h" 9 #include "test/unittests/test-utils.h"
10 10
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 // Emit wide load / store property operations. 226 // Emit wide load / store property operations.
227 builder.LoadNamedProperty(reg, wide_name, 0, LanguageMode::SLOPPY) 227 builder.LoadNamedProperty(reg, wide_name, 0, LanguageMode::SLOPPY)
228 .LoadKeyedProperty(reg, 2056, LanguageMode::SLOPPY) 228 .LoadKeyedProperty(reg, 2056, LanguageMode::SLOPPY)
229 .StoreNamedProperty(reg, wide_name, 0, LanguageMode::SLOPPY) 229 .StoreNamedProperty(reg, wide_name, 0, LanguageMode::SLOPPY)
230 .StoreKeyedProperty(reg, reg, 2056, LanguageMode::SLOPPY) 230 .StoreKeyedProperty(reg, reg, 2056, LanguageMode::SLOPPY)
231 .LoadNamedProperty(reg, wide_name, 0, LanguageMode::STRICT) 231 .LoadNamedProperty(reg, wide_name, 0, LanguageMode::STRICT)
232 .LoadKeyedProperty(reg, 2056, LanguageMode::STRICT) 232 .LoadKeyedProperty(reg, 2056, LanguageMode::STRICT)
233 .StoreNamedProperty(reg, wide_name, 0, LanguageMode::STRICT) 233 .StoreNamedProperty(reg, wide_name, 0, LanguageMode::STRICT)
234 .StoreKeyedProperty(reg, reg, 2056, LanguageMode::STRICT); 234 .StoreKeyedProperty(reg, reg, 2056, LanguageMode::STRICT);
235 235
236 // Emit wide load / store lookup slots.
237 builder.LoadLookupSlot(wide_name, TypeofMode::NOT_INSIDE_TYPEOF)
238 .LoadLookupSlot(wide_name, TypeofMode::INSIDE_TYPEOF)
239 .StoreLookupSlot(wide_name, LanguageMode::SLOPPY)
240 .StoreLookupSlot(wide_name, LanguageMode::STRICT);
241
236 // CreateClosureWide 242 // CreateClosureWide
237 Handle<SharedFunctionInfo> shared_info2 = factory->NewSharedFunctionInfo( 243 Handle<SharedFunctionInfo> shared_info2 = factory->NewSharedFunctionInfo(
238 factory->NewStringFromStaticChars("function_b"), MaybeHandle<Code>(), 244 factory->NewStringFromStaticChars("function_b"), MaybeHandle<Code>(),
239 false); 245 false);
240 builder.CreateClosure(shared_info2, NOT_TENURED); 246 builder.CreateClosure(shared_info2, NOT_TENURED);
241 247
242 // Emit wide variant of literal creation operations. 248 // Emit wide variant of literal creation operations.
243 builder.CreateRegExpLiteral(factory->NewStringFromStaticChars("wide_literal"), 249 builder.CreateRegExpLiteral(factory->NewStringFromStaticChars("wide_literal"),
244 0, 0) 250 0, 0)
245 .CreateArrayLiteral(factory->NewFixedArray(2), 0, 0) 251 .CreateArrayLiteral(factory->NewFixedArray(2), 0, 0)
(...skipping 428 matching lines...) Expand 10 before | Expand all | Expand 10 after
674 iterator.Advance(); 680 iterator.Advance();
675 } 681 }
676 CHECK_EQ(iterator.current_bytecode(), Bytecode::kReturn); 682 CHECK_EQ(iterator.current_bytecode(), Bytecode::kReturn);
677 iterator.Advance(); 683 iterator.Advance();
678 CHECK(iterator.done()); 684 CHECK(iterator.done());
679 } 685 }
680 686
681 } // namespace interpreter 687 } // namespace interpreter
682 } // namespace internal 688 } // namespace internal
683 } // namespace v8 689 } // namespace v8
OLDNEW
« no previous file with comments | « test/cctest/interpreter/test-interpreter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698