Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1555043005: Use standard font for print preview (Closed)

Created:
4 years, 11 months ago by mdjones
Modified:
4 years, 11 months ago
Reviewers:
wychen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use standard font for print preview Using a web font in print preview can cause text to not be rendered. This change forces the content font to be "sans-serif" when the media is print. BUG=571373 Committed: https://crrev.com/bf8db4e129b234ee4a7be079d985d18a6ba5486e Cr-Commit-Position: refs/heads/master@{#367885}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/dom_distiller/core/css/distilledpage.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mdjones
PTAL
4 years, 11 months ago (2016-01-05 01:30:47 UTC) #2
wychen
lgtm, but we might need second opinion from UX experts.
4 years, 11 months ago (2016-01-05 23:51:22 UTC) #3
mdjones
On 2016/01/05 23:51:22, wychen wrote: > lgtm, but we might need second opinion from UX ...
4 years, 11 months ago (2016-01-06 19:03:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555043005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555043005/1
4 years, 11 months ago (2016-01-06 19:03:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 19:59:18 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 20:00:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf8db4e129b234ee4a7be079d985d18a6ba5486e
Cr-Commit-Position: refs/heads/master@{#367885}

Powered by Google App Engine
This is Rietveld 408576698