Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1555013002:
Make emphasis mark glyph data retrieval independent of code path (Closed)
|
Created:
4 years, 11 months ago by drott Modified:
4 years, 11 months ago CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, danakj, Rik, f(malita), blink-reviews, vmpstr+blinkwatch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake emphasis mark glyph data retrieval independent of code path
Looking up the glyph data for emphasis marks was still dependent on the
simple path. Change this implementation to use buildGlyphBuffer() and
become independent of the code path. This should be the last blocker for
removing the simple code path.
Rebaselines for improved size of .notdef glyph. Latin and other non-
upright in vertical characters are default-sideways. I cannot find
anything in the spec regarding the orientation of non-CJK emphasis
marks, so it should be fine not to do any special casing for their
orientation.
BUG=561426
R=eae
Committed: https://crrev.com/6a8c5a29250629da84dd967b2883b4fd961f54ce
Cr-Commit-Position: refs/heads/master@{#367330}
Patch Set 1 #Patch Set 2 : Rebaselines for better .notdef sized, default sideways for non-CJK marks #Patch Set 3 : Additional win rebaselines #
Messages
Total messages: 21 (11 generated)
Description was changed from ========== Make emphasis mark glyph data retrieval independent of code path Looking up the glyph data for emphasis marks was still dependant on the simple path. Change this implementation to use buildGlyphBuffer() and become independent of the code path. This should be the last blocker for removing the simple code path. BUG=561426 R=eae ========== to ========== Make emphasis mark glyph data retrieval independent of code path Looking up the glyph data for emphasis marks was still dependent on the simple path. Change this implementation to use buildGlyphBuffer() and become independent of the code path. This should be the last blocker for removing the simple code path. BUG=561426 R=eae ==========
drott@chromium.org changed reviewers: + kojii@chromium.org
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555013002/20001
Description was changed from ========== Make emphasis mark glyph data retrieval independent of code path Looking up the glyph data for emphasis marks was still dependent on the simple path. Change this implementation to use buildGlyphBuffer() and become independent of the code path. This should be the last blocker for removing the simple code path. BUG=561426 R=eae ========== to ========== Make emphasis mark glyph data retrieval independent of code path Looking up the glyph data for emphasis marks was still dependent on the simple path. Change this implementation to use buildGlyphBuffer() and become independent of the code path. This should be the last blocker for removing the simple code path. Rebaselines for improved size of .notdef glyph. Latin and other non- upright in vertical characters are default-sideways. I cannot find anything in the spec regarding the orientation of non-CJK emphasis marks, so it should be fine to not do any special casing for their orientation. BUG=561426 R=eae ==========
Description was changed from ========== Make emphasis mark glyph data retrieval independent of code path Looking up the glyph data for emphasis marks was still dependent on the simple path. Change this implementation to use buildGlyphBuffer() and become independent of the code path. This should be the last blocker for removing the simple code path. Rebaselines for improved size of .notdef glyph. Latin and other non- upright in vertical characters are default-sideways. I cannot find anything in the spec regarding the orientation of non-CJK emphasis marks, so it should be fine to not do any special casing for their orientation. BUG=561426 R=eae ========== to ========== Make emphasis mark glyph data retrieval independent of code path Looking up the glyph data for emphasis marks was still dependent on the simple path. Change this implementation to use buildGlyphBuffer() and become independent of the code path. This should be the last blocker for removing the simple code path. Rebaselines for improved size of .notdef glyph. Latin and other non- upright in vertical characters are default-sideways. I cannot find anything in the spec regarding the orientation of non-CJK emphasis marks, so it should be fine not to do any special casing for their orientation. BUG=561426 R=eae ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Additional win rebaselines
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555013002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
This is great, thank you! LGTM
The CQ bit was checked by drott@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555013002/40001
Message was sent while issue was closed.
Description was changed from ========== Make emphasis mark glyph data retrieval independent of code path Looking up the glyph data for emphasis marks was still dependent on the simple path. Change this implementation to use buildGlyphBuffer() and become independent of the code path. This should be the last blocker for removing the simple code path. Rebaselines for improved size of .notdef glyph. Latin and other non- upright in vertical characters are default-sideways. I cannot find anything in the spec regarding the orientation of non-CJK emphasis marks, so it should be fine not to do any special casing for their orientation. BUG=561426 R=eae ========== to ========== Make emphasis mark glyph data retrieval independent of code path Looking up the glyph data for emphasis marks was still dependent on the simple path. Change this implementation to use buildGlyphBuffer() and become independent of the code path. This should be the last blocker for removing the simple code path. Rebaselines for improved size of .notdef glyph. Latin and other non- upright in vertical characters are default-sideways. I cannot find anything in the spec regarding the orientation of non-CJK emphasis marks, so it should be fine not to do any special casing for their orientation. BUG=561426 R=eae ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Make emphasis mark glyph data retrieval independent of code path Looking up the glyph data for emphasis marks was still dependent on the simple path. Change this implementation to use buildGlyphBuffer() and become independent of the code path. This should be the last blocker for removing the simple code path. Rebaselines for improved size of .notdef glyph. Latin and other non- upright in vertical characters are default-sideways. I cannot find anything in the spec regarding the orientation of non-CJK emphasis marks, so it should be fine not to do any special casing for their orientation. BUG=561426 R=eae ========== to ========== Make emphasis mark glyph data retrieval independent of code path Looking up the glyph data for emphasis marks was still dependent on the simple path. Change this implementation to use buildGlyphBuffer() and become independent of the code path. This should be the last blocker for removing the simple code path. Rebaselines for improved size of .notdef glyph. Latin and other non- upright in vertical characters are default-sideways. I cannot find anything in the spec regarding the orientation of non-CJK emphasis marks, so it should be fine not to do any special casing for their orientation. BUG=561426 R=eae Committed: https://crrev.com/6a8c5a29250629da84dd967b2883b4fd961f54ce Cr-Commit-Position: refs/heads/master@{#367330} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6a8c5a29250629da84dd967b2883b4fd961f54ce Cr-Commit-Position: refs/heads/master@{#367330} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
