Issue 1554723003: Set LIBCXX_BUILDING_LIBCXXABI when buildng libc++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1554723003: Set LIBCXX_BUILDING_LIBCXXABI when buildng libc++. (Closed)

Created:
4 years, 11 months ago by Nico

Modified:
4 years, 11 months ago

Reviewers:
Lei Zhang

CC:
Alexander Potapenko, chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/buildtools.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Set LIBCXX_BUILDING_LIBCXXABI when buildng libc++. This is now apparently necessary to let libc++ know it's building against libc++abi. BUG=573250 TBR=thestig@chromium.org Committed: 71d2e70bfd5ae0a2388abc49ac064c5d35e3c2df

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	third_party/libc++/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	third_party/libc++/libc++.gyp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Nico

Committed patchset #1 (id:1) manually as 71d2e70bfd5ae0a2388abc49ac064c5d35e3c2df (presubmit successful).

4 years, 11 months ago (2015-12-30 18:54:36 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages