Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: third_party/libc++/BUILD.gn

Issue 1554723003: Set LIBCXX_BUILDING_LIBCXXABI when buildng libc++. (Closed) Base URL: https://chromium.googlesource.com/chromium/buildtools.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/libc++/libc++.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("config") { 5 config("config") {
6 include_dirs = [ 6 include_dirs = [
7 "trunk/include", 7 "trunk/include",
8 "../libc++abi/trunk/include", 8 "../libc++abi/trunk/include",
9 ] 9 ]
10 cflags = [ 10 cflags = [
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 "//build/config/gcc:no_exceptions", 53 "//build/config/gcc:no_exceptions",
54 "//build/config/gcc:symbol_visibility_hidden", 54 "//build/config/gcc:symbol_visibility_hidden",
55 ] 55 ]
56 configs += [ 56 configs += [
57 ":config", 57 ":config",
58 "//build/config/compiler:no_chromium_code", 58 "//build/config/compiler:no_chromium_code",
59 "//build/config/compiler:rtti", 59 "//build/config/compiler:rtti",
60 "//build/config/sanitizers:sanitizer_options_link_helper", 60 "//build/config/sanitizers:sanitizer_options_link_helper",
61 ] 61 ]
62 62
63 defines = [ "LIBCXX_BUILDING_LIBCXXABI" ]
63 ldflags = [ "-nodefaultlibs" ] 64 ldflags = [ "-nodefaultlibs" ]
64 65
65 # TODO(GYP): Remove "-pthread" from ldflags. 66 # TODO(GYP): Remove "-pthread" from ldflags.
66 # -nodefaultlibs turns -pthread into a no-op, causing an unused argument 67 # -nodefaultlibs turns -pthread into a no-op, causing an unused argument
67 # warning. Explicitly link with -lpthread instead. 68 # warning. Explicitly link with -lpthread instead.
68 69
69 libs = [ 70 libs = [
70 "c", 71 "c",
71 "gcc_s", 72 "gcc_s",
72 "m", 73 "m",
(...skipping 21 matching lines...) Expand all
94 "-stdlib=libc++", 95 "-stdlib=libc++",
95 96
96 # Normally the generator takes care of RPATH. Our case is special because 97 # Normally the generator takes care of RPATH. Our case is special because
97 # the generator is unaware of the libc++.so dependency. Note that setting 98 # the generator is unaware of the libc++.so dependency. Note that setting
98 # RPATH here is a potential security issue. See the following for another 99 # RPATH here is a potential security issue. See the following for another
99 # example of this issue: https://code.google.com/p/gyp/issues/detail?id=315 100 # example of this issue: https://code.google.com/p/gyp/issues/detail?id=315
100 "-Wl,-R,\$ORIGIN/", 101 "-Wl,-R,\$ORIGIN/",
101 ] 102 ]
102 lib_dirs = [ root_build_dir ] 103 lib_dirs = [ root_build_dir ]
103 } 104 }
OLDNEW
« no previous file with comments | « no previous file | third_party/libc++/libc++.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698