Put more files under the enable_service_discovery build flag.

Put more files under the enable_service_discovery build flag.

TBR=thakis@chromium.org

Committed: https://crrev.com/09de2b88725e565520cc5506593cc6f58251710a
Cr-Commit-Position: refs/heads/master@{#367872}

[Lei Zhang, 2015-12-29 20:18:12]

thestig@chromium.org changed reviewers:
+ vitalybuka@chromium.org

[Vitaly Buka (NO REVIEWS), 2016-01-04 23:10:47]

https://codereview.chromium.org/1554563002/diff/20001/chrome/browser/devtools...
File chrome/browser/devtools/BUILD.gn (right):

https://codereview.chromium.org/1554563002/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/BUILD.gn:136: if (enable_service_discovery) {
I guess it's always enabled on platforms with devtools.

https://codereview.chromium.org/1554563002/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/BUILD.gn:141: "device/webrtc/devtools_bridge_client.h",
Some of these files depend on gcd_api_flow.cc only. That file is under
local_discovery but it has nothing to do with it.
It just browser to server communication.

Plan was to make it wrapper that picks local vs server protocol inside. But this
is not going to happen any more. So best place for gcd_api_flow.cc is probably
components/cloud_devices/ 

I started to that as part of crbug.com/551631

Technically with current state of the code your CL is still correct.
Can you wait until I move that file so you can avoid changing webrtc stuff?

[Vitaly Buka (NO REVIEWS), 2016-01-05 01:18:13]

https://codereview.chromium.org/1554563002/diff/20001/chrome/browser/devtools...
File chrome/browser/devtools/BUILD.gn (right):

https://codereview.chromium.org/1554563002/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/BUILD.gn:144: "device/webrtc/send_command_request.cc",
Actually this code is obsolete and going away:
https://codereview.chromium.org/1560583002/

[Lei Zhang, 2016-01-05 02:36:10]

https://codereview.chromium.org/1554563002/diff/20001/chrome/browser/devtools...
File chrome/browser/devtools/BUILD.gn (right):

https://codereview.chromium.org/1554563002/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/BUILD.gn:144: "device/webrtc/send_command_request.cc",
On 2016/01/05 01:18:13, Vitaly Buka wrote:
> Actually this code is obsolete and going away:
> https://codereview.chromium.org/1560583002/

I'll wait for that to land and see what we end up with here. No rush.

[Vitaly Buka (NO REVIEWS), 2016-01-05 02:38:21]

On 2016/01/05 02:36:10, Lei Zhang wrote:
>
https://codereview.chromium.org/1554563002/diff/20001/chrome/browser/devtools...
> File chrome/browser/devtools/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1554563002/diff/20001/chrome/browser/devtools...
> chrome/browser/devtools/BUILD.gn:144: "device/webrtc/send_command_request.cc",
> On 2016/01/05 01:18:13, Vitaly Buka wrote:
> > Actually this code is obsolete and going away:
> > https://codereview.chromium.org/1560583002/
> 
> I'll wait for that to land and see what we end up with here. No rush.

Maybe you would like to stamp that one as OWNER.

[Lei Zhang, 2016-01-05 02:47:20]

On 2016/01/05 02:38:21, Vitaly Buka wrote:
> Maybe you would like to stamp that one as OWNER.

You read my mind.

[Vitaly Buka (NO REVIEWS), 2016-01-06 02:15:09]

lgtm

https://codereview.chromium.org/1554563002/diff/40001/chrome/browser/devtools...
File chrome/browser/devtools/BUILD.gn (right):

https://codereview.chromium.org/1554563002/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/BUILD.gn:139: "device/webrtc/devtools_bridge_client.cc",
device/webrtc is gone, so all webrtc changes can be reverted
cast_device_provider.cc is still could be guarded by enable_service_discovery

btw. we probably have no builds with devtools and without
enable_service_discovery

[Vitaly Buka (NO REVIEWS), 2016-01-06 02:17:16]

On 2016/01/06 02:15:09, Vitaly Buka wrote:
> lgtm
> 
>
https://codereview.chromium.org/1554563002/diff/40001/chrome/browser/devtools...
> File chrome/browser/devtools/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1554563002/diff/40001/chrome/browser/devtools...
> chrome/browser/devtools/BUILD.gn:139:
"device/webrtc/devtools_bridge_client.cc",
> device/webrtc is gone, so all webrtc changes can be reverted
> cast_device_provider.cc is still could be guarded by enable_service_discovery
> 
> btw. we probably have no builds with devtools and without
> enable_service_discovery

That was sent by mistake for wrong snapshot.

LGTM

[Lei Zhang, 2016-01-06 02:28:57]

On 2016/01/06 02:17:16, Vitaly Buka wrote:
> btw. we probably have no builds with devtools and without
> enable_service_discovery

Correct. I'll check manually. I'm aware it may break in the future.

> That was sent by mistake for wrong snapshot.

Thanks. I was still self-reviewing and fixing all the bad merges.

[Vitaly Buka (NO REVIEWS), 2016-01-06 18:41:14]

CQ?

[Lei Zhang, 2016-01-06 18:42:04]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-01-06 18:42:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1554563002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1554563002/80001

[commit-bot: I haz the power, 2016-01-06 18:51:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-06 18:51:14]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Lei Zhang, 2016-01-06 18:54:15]

Description was changed from

==========
Put more files under the enable_service_discovery build flag.
==========

to

==========
Put more files under the enable_service_discovery build flag.

TBR=thakis@chromium.org
==========

[Lei Zhang, 2016-01-06 18:54:15]

thestig@chromium.org changed reviewers:
+ thakis@chromium.org

[Lei Zhang, 2016-01-06 18:54:30]

TBR for a trivial whitespace change in build/

[Lei Zhang, 2016-01-06 18:54:42]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-01-06 18:55:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1554563002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1554563002/80001

[commit-bot: I haz the power, 2016-01-06 19:04:20]

Description was changed from

==========
Put more files under the enable_service_discovery build flag.

TBR=thakis@chromium.org
==========

to

==========
Put more files under the enable_service_discovery build flag.

TBR=thakis@chromium.org
==========

[commit-bot: I haz the power, 2016-01-06 19:04:20]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-06 19:05:07]

Description was changed from

==========
Put more files under the enable_service_discovery build flag.

TBR=thakis@chromium.org
==========

to

==========
Put more files under the enable_service_discovery build flag.

TBR=thakis@chromium.org

Committed: https://crrev.com/09de2b88725e565520cc5506593cc6f58251710a
Cr-Commit-Position: refs/heads/master@{#367872}
==========

[commit-bot: I haz the power, 2016-01-06 19:05:08]

Patchset 5 (id:??) landed as
https://crrev.com/09de2b88725e565520cc5506593cc6f58251710a
Cr-Commit-Position: refs/heads/master@{#367872}

[Nico, 2016-01-06 19:05:27]

build/ lgtm