Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1553333002: Move cloud print specific files out of local_discovery (Closed)

Created:
4 years, 11 months ago by Vitaly Buka (NO REVIEWS)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-options_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@moveprn
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move cloud print specific files out of local_discovery Privet printing is part of GCP2.0 spec. It depends on local_discovery but it's not part of it. So better to move under printing/cloud_print/. BUG=551631 Committed: https://crrev.com/33d7a06d03a2893108ddd74e5500ebf6630d1138 Cr-Commit-Position: refs/heads/master@{#367931}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 4

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+470 lines, -7474 lines) Patch
D chrome/browser/local_discovery/cloud_print_printer_list.h View 1 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/browser/local_discovery/cloud_print_printer_list.cc View 1 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/local_discovery/cloud_print_printer_list_unittest.cc View 1 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/local_discovery/device_description.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/local_discovery/device_description.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/local_discovery/gcd_api_flow.h View 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/browser/local_discovery/gcd_api_flow.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/local_discovery/gcd_api_flow_impl.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/local_discovery/gcd_api_flow_impl.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/local_discovery/gcd_api_flow_unittest.cc View 1 chunk +0 lines, -134 lines 0 comments Download
D chrome/browser/local_discovery/gcd_constants.h View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/local_discovery/gcd_constants.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/local_discovery/privet_confirm_api_flow.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/local_discovery/privet_confirm_api_flow.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/local_discovery/privet_confirm_api_flow_unittest.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/local_discovery/privet_constants.h View 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/browser/local_discovery/privet_constants.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/local_discovery/privet_device_lister.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/local_discovery/privet_device_lister.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/browser/local_discovery/privet_device_lister_impl.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/local_discovery/privet_device_lister_impl.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/local_discovery/privet_device_lister_unittest.cc View 1 chunk +0 lines, -312 lines 0 comments Download
D chrome/browser/local_discovery/privet_http.h View 1 chunk +0 lines, -214 lines 0 comments Download
D chrome/browser/local_discovery/privet_http.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/local_discovery/privet_http_asynchronous_factory.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/local_discovery/privet_http_asynchronous_factory.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.h View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/local_discovery/privet_http_asynchronous_factory_impl.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/local_discovery/privet_http_impl.h View 1 chunk +0 lines, -298 lines 0 comments Download
D chrome/browser/local_discovery/privet_http_impl.cc View 1 chunk +0 lines, -804 lines 0 comments Download
D chrome/browser/local_discovery/privet_http_unittest.cc View 1 chunk +0 lines, -1121 lines 0 comments Download
D chrome/browser/local_discovery/privet_local_printer_lister.h View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/local_discovery/privet_local_printer_lister.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D chrome/browser/local_discovery/privet_local_printer_lister_unittest.cc View 1 chunk +0 lines, -193 lines 0 comments Download
D chrome/browser/local_discovery/privet_notifications.h View 1 chunk +0 lines, -150 lines 0 comments Download
D chrome/browser/local_discovery/privet_notifications.cc View 1 chunk +0 lines, -393 lines 0 comments Download
D chrome/browser/local_discovery/privet_notifications_factory.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/local_discovery/privet_notifications_factory.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/local_discovery/privet_notifications_unittest.cc View 1 chunk +0 lines, -217 lines 0 comments Download
D chrome/browser/local_discovery/privet_traffic_detector.h View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/local_discovery/privet_traffic_detector.cc View 1 chunk +0 lines, -203 lines 0 comments Download
D chrome/browser/local_discovery/privet_url_fetcher.h View 1 chunk +0 lines, -147 lines 0 comments Download
D chrome/browser/local_discovery/privet_url_fetcher.cc View 1 chunk +0 lines, -389 lines 0 comments Download
D chrome/browser/local_discovery/privet_url_fetcher_unittest.cc View 1 chunk +0 lines, -302 lines 0 comments Download
D chrome/browser/local_discovery/pwg_raster_converter.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/local_discovery/pwg_raster_converter.cc View 1 chunk +0 lines, -366 lines 0 comments Download
A + chrome/browser/printing/cloud_print/cloud_print_printer_list.h View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/printing/cloud_print/cloud_print_printer_list.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/printing/cloud_print/cloud_print_printer_list_unittest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/printing/cloud_print/device_description.h View 3 chunks +9 lines, -6 lines 0 comments Download
A + chrome/browser/printing/cloud_print/device_description.cc View 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/printing/cloud_print/gcd_api_flow.h View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/printing/cloud_print/gcd_api_flow.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/printing/cloud_print/gcd_api_flow_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/printing/cloud_print/gcd_api_flow_impl.cc View 1 2 6 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/printing/cloud_print/gcd_api_flow_unittest.cc View 1 2 6 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/printing/cloud_print/gcd_constants.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + chrome/browser/printing/cloud_print/gcd_constants.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_confirm_api_flow.h View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_confirm_api_flow.cc View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_confirm_api_flow_unittest.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_constants.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_constants.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_device_lister.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_device_lister.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_device_lister_impl.h View 2 chunks +17 lines, -13 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_device_lister_impl.cc View 3 chunks +8 lines, -7 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc View 1 2 2 chunks +9 lines, -4 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_http.h View 4 chunks +9 lines, -8 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_http.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_http_asynchronous_factory.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_http_asynchronous_factory.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_http_asynchronous_factory_impl.h View 3 chunks +10 lines, -8 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_http_asynchronous_factory_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_http_impl.h View 5 chunks +9 lines, -8 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_http_impl.cc View 6 chunks +7 lines, -6 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_http_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_local_printer_lister.h View 3 chunks +12 lines, -11 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_local_printer_lister.cc View 3 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_local_printer_lister_unittest.cc View 4 chunks +7 lines, -5 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_notifications.h View 3 chunks +13 lines, -9 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_notifications.cc View 6 chunks +10 lines, -8 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_notifications_factory.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_notifications_factory.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_notifications_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_traffic_detector.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_traffic_detector.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_url_fetcher.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_url_fetcher.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/printing/cloud_print/privet_url_fetcher_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/printing/pwg_raster_converter.h View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -11 lines 0 comments Download
A + chrome/browser/printing/pwg_raster_converter.cc View 1 2 3 4 5 6 7 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h View 1 7 chunks +44 lines, -36 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc View 1 2 7 chunks +25 lines, -17 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/extension_printer_handler.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/extension_printer_handler.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 1 2 6 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 12 chunks +15 lines, -15 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 5 chunks +38 lines, -38 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 49 (28 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553333002/1
4 years, 11 months ago (2016-01-05 04:57:10 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/154320) mac_chromium_compile_dbg_ng on ...
4 years, 11 months ago (2016-01-05 05:00:06 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553333002/40001
4 years, 11 months ago (2016-01-05 23:19:06 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/98293) chromeos_amd64-generic_chromium_compile_only_ng on ...
4 years, 11 months ago (2016-01-05 23:25:58 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553333002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553333002/60001
4 years, 11 months ago (2016-01-05 23:30:25 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/48715)
4 years, 11 months ago (2016-01-05 23:52:07 UTC) #16
Aleksey Shlyapnikov
lgtm
4 years, 11 months ago (2016-01-06 02:50:43 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553333002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553333002/80001
4 years, 11 months ago (2016-01-06 04:20:54 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/113227)
4 years, 11 months ago (2016-01-06 04:33:47 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553333002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553333002/100001
4 years, 11 months ago (2016-01-06 05:23:09 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/161117)
4 years, 11 months ago (2016-01-06 06:27:49 UTC) #26
commit-bot: I haz the power
This CL has an open dependency (Issue 1554563002 Patch 80001). Please resolve the dependency and ...
4 years, 11 months ago (2016-01-06 18:40:50 UTC) #32
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553333002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553333002/120001
4 years, 11 months ago (2016-01-06 19:19:49 UTC) #34
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/155100)
4 years, 11 months ago (2016-01-06 19:35:03 UTC) #36
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553333002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553333002/120001
4 years, 11 months ago (2016-01-06 20:14:23 UTC) #38
Lei Zhang
lgtm, just nits: https://codereview.chromium.org/1553333002/diff/120001/chrome/browser/printing/pwg_raster_converter.h File chrome/browser/printing/pwg_raster_converter.h (right): https://codereview.chromium.org/1553333002/diff/120001/chrome/browser/printing/pwg_raster_converter.h#newcode44 chrome/browser/printing/pwg_raster_converter.h:44: static printing::PdfRenderSettings GetConversionSettings( no need for ...
4 years, 11 months ago (2016-01-06 20:16:21 UTC) #39
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-06 20:21:40 UTC) #41
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/1553333002/diff/120001/chrome/browser/printing/pwg_raster_converter.h File chrome/browser/printing/pwg_raster_converter.h (right): https://codereview.chromium.org/1553333002/diff/120001/chrome/browser/printing/pwg_raster_converter.h#newcode44 chrome/browser/printing/pwg_raster_converter.h:44: static printing::PdfRenderSettings GetConversionSettings( On 2016/01/06 20:16:21, Lei Zhang wrote: ...
4 years, 11 months ago (2016-01-06 21:26:21 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553333002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553333002/160001
4 years, 11 months ago (2016-01-06 21:27:09 UTC) #45
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 11 months ago (2016-01-06 22:11:51 UTC) #47
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 22:12:52 UTC) #49
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/33d7a06d03a2893108ddd74e5500ebf6630d1138
Cr-Commit-Position: refs/heads/master@{#367931}

Powered by Google App Engine
This is Rietveld 408576698