port alternative_locale_resource to GN.

port alternative_locale_resource to GN.

Suppport to override existing locale resources in dep graph for
android_apk targets.

- Used is_locale_resource in build_config file to indicate that
  android_resources is locale_resource

- Removed all locale_resource in deps graph if
  alternative_locale_resource_dep is specified in android_apk target.

This feature was implemented in gyp.

BUG=565532
Committed: https://crrev.com/37d60adb473ac4e3038bc73c31c564bc0096e80f
Cr-Commit-Position: refs/heads/master@{#367182}

[michaelbai, 2015-12-29 23:37:26]

Description was changed from

==========
port alternative_locale_resource to GN.

Suppport to override existing locale resources in dep graph for
android_apk targets.

- Used is_locale_resource in build_config file to indicate that
  android_resources is locale_resource

- Removed all locale_resource in deps graph if
  alternative_locale_resource_dep is specified in android_apk target.

This feature was implemented in gyp.

BUG=565532
==========

to

==========
port alternative_locale_resource to GN.

Suppport to override existing locale resources in dep graph for
android_apk targets.

- Used is_locale_resource in build_config file to indicate that
  android_resources is locale_resource

- Removed all locale_resource in deps graph if
  alternative_locale_resource_dep is specified in android_apk target.

This feature was implemented in gyp.

BUG=565532
==========

[michaelbai, 2015-12-29 23:37:27]

michaelbai@chromium.org changed reviewers:
+ agrieve@chromium.org

[michaelbai, 2015-12-29 23:59:09]

On 2015/12/29 23:37:36, michaelbai wrote:

See how it is used

https://chrome-internal-review.googlesource.com/#/c/241966/2/java/BUILD.gn

[agrieve, 2015-12-30 15:22:15]

lgtm

https://codereview.chromium.org/1554533003/diff/40001/build/android/gyp/write...
File build/android/gyp/write_build_config.py (right):

https://codereview.chromium.org/1554533003/diff/40001/build/android/gyp/write...
build/android/gyp/write_build_config.py:119: def RemoveNoneDirectDep(self,
path):
nit: RemoveNoneDirectDep -> RemoveNonDirectDep

https://codereview.chromium.org/1554533003/diff/40001/build/android/gyp/write...
build/android/gyp/write_build_config.py:121: raise Exception('Can not remove
direct dep')
nit: Can not -> Cannot (although assert() might be more appropriate here?)

https://codereview.chromium.org/1554533003/diff/40001/build/android/gyp/write...
build/android/gyp/write_build_config.py:123: self.all_deps_configs = [
nit: GetDepConfig() caches, so you can just do: 
    self.all_deps_configs.remove(GetDepConfig(path))

https://codereview.chromium.org/1554533003/diff/40001/build/android/gyp/write...
build/android/gyp/write_build_config.py:282: alternative = [ r['path'] for r in
deps.Direct('android_resources')
nit: whitespace is off here. should be:
 - No space after [ nor before ]
 - "if" should align with r[

https://codereview.chromium.org/1554533003/diff/40001/build/android/gyp/write...
build/android/gyp/write_build_config.py:288: unwanted = [ r['path'] for r in
deps.All('android_resources')
same here

[michaelbai, 2015-12-30 19:29:49]

https://codereview.chromium.org/1554533003/diff/40001/build/android/gyp/write...
File build/android/gyp/write_build_config.py (right):

https://codereview.chromium.org/1554533003/diff/40001/build/android/gyp/write...
build/android/gyp/write_build_config.py:119: def RemoveNoneDirectDep(self,
path):
On 2015/12/30 15:22:15, agrieve wrote:
> nit: RemoveNoneDirectDep -> RemoveNonDirectDep

Done.

https://codereview.chromium.org/1554533003/diff/40001/build/android/gyp/write...
build/android/gyp/write_build_config.py:121: raise Exception('Can not remove
direct dep')
On 2015/12/30 15:22:15, agrieve wrote:
> nit: Can not -> Cannot (although assert() might be more appropriate here?)

Done.

https://codereview.chromium.org/1554533003/diff/40001/build/android/gyp/write...
build/android/gyp/write_build_config.py:123: self.all_deps_configs = [
On 2015/12/30 15:22:15, agrieve wrote:
> nit: GetDepConfig() caches, so you can just do: 
>     self.all_deps_configs.remove(GetDepConfig(path))

Done.

https://codereview.chromium.org/1554533003/diff/40001/build/android/gyp/write...
build/android/gyp/write_build_config.py:282: alternative = [ r['path'] for r in
deps.Direct('android_resources')
On 2015/12/30 15:22:15, agrieve wrote:
> nit: whitespace is off here. should be:
>  - No space after [ nor before ]
>  - "if" should align with r[

Done.

https://codereview.chromium.org/1554533003/diff/40001/build/android/gyp/write...
build/android/gyp/write_build_config.py:288: unwanted = [ r['path'] for r in
deps.All('android_resources')
On 2015/12/30 15:22:14, agrieve wrote:
> same here

Done.

[michaelbai, 2015-12-30 19:29:59]

The CQ bit was checked by michaelbai@chromium.org

[michaelbai, 2015-12-30 19:29:59]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/1554533003/#ps60001
(title: "address comments")

[commit-bot: I haz the power, 2015-12-30 19:30:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1554533003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1554533003/60001

[commit-bot: I haz the power, 2015-12-30 20:46:36]

Description was changed from

==========
port alternative_locale_resource to GN.

Suppport to override existing locale resources in dep graph for
android_apk targets.

- Used is_locale_resource in build_config file to indicate that
  android_resources is locale_resource

- Removed all locale_resource in deps graph if
  alternative_locale_resource_dep is specified in android_apk target.

This feature was implemented in gyp.

BUG=565532
==========

to

==========
port alternative_locale_resource to GN.

Suppport to override existing locale resources in dep graph for
android_apk targets.

- Used is_locale_resource in build_config file to indicate that
  android_resources is locale_resource

- Removed all locale_resource in deps graph if
  alternative_locale_resource_dep is specified in android_apk target.

This feature was implemented in gyp.

BUG=565532
==========

[commit-bot: I haz the power, 2015-12-30 20:46:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-30 20:48:43]

Description was changed from

==========
port alternative_locale_resource to GN.

Suppport to override existing locale resources in dep graph for
android_apk targets.

- Used is_locale_resource in build_config file to indicate that
  android_resources is locale_resource

- Removed all locale_resource in deps graph if
  alternative_locale_resource_dep is specified in android_apk target.

This feature was implemented in gyp.

BUG=565532
==========

to

==========
port alternative_locale_resource to GN.

Suppport to override existing locale resources in dep graph for
android_apk targets.

- Used is_locale_resource in build_config file to indicate that
  android_resources is locale_resource

- Removed all locale_resource in deps graph if
  alternative_locale_resource_dep is specified in android_apk target.

This feature was implemented in gyp.

BUG=565532

Committed: https://crrev.com/37d60adb473ac4e3038bc73c31c564bc0096e80f
Cr-Commit-Position: refs/heads/master@{#367182}
==========

[commit-bot: I haz the power, 2015-12-30 20:48:44]

Patchset 4 (id:??) landed as
https://crrev.com/37d60adb473ac4e3038bc73c31c564bc0096e80f
Cr-Commit-Position: refs/heads/master@{#367182}