port alternative_locale_resource to GN.

build/android/gyp/write_build_config.py

 #!/usr/bin/env python
 #
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Writes a build_config file.
 
 The build_config file for a target is a json file containing information about
 how to build that target based on the target's dependencies. This includes
@@ skipping 83 matching lines @@
 
 
 class Deps(object):
   def __init__(self, direct_deps_config_paths):
     self.all_deps_config_paths = GetAllDepsConfigsInOrder(
         direct_deps_config_paths)
     self.direct_deps_configs = [
         GetDepConfig(p) for p in direct_deps_config_paths]
     self.all_deps_configs = [
         GetDepConfig(p) for p in self.all_deps_config_paths]
+    self.direct_deps_config_paths = direct_deps_config_paths
 
   def All(self, wanted_type=None):
     if type is None:
       return self.all_deps_configs
     return DepsOfType(wanted_type, self.all_deps_configs)
 
   def Direct(self, wanted_type=None):
     if wanted_type is None:
       return self.direct_deps_configs
     return DepsOfType(wanted_type, self.direct_deps_configs)
 
   def AllConfigPaths(self):
     return self.all_deps_config_paths
 
+  def RemoveNoneDirectDep(self, path):

[agrieve, 2015/12/30 15:22:15]

nit: RemoveNoneDirectDep -> RemoveNonDirectDep

[michaelbai, 2015/12/30 19:29:48]

Done.

+    if path in self.direct_deps_config_paths:
+      raise Exception('Can not remove direct dep')

[agrieve, 2015/12/30 15:22:15]

nit: Can not -> Cannot (although assert() might be more appropriate here?)

[michaelbai, 2015/12/30 19:29:48]

Done.

+    self.all_deps_config_paths.remove(path)
+    self.all_deps_configs = [

[agrieve, 2015/12/30 15:22:15]

nit: GetDepConfig() caches, so you can just do: 
    self.all_deps_configs.remove(GetDepConfig(path))

[michaelbai, 2015/12/30 19:29:48]

Done.

+        GetDepConfig(p) for p in self.all_deps_config_paths]
 
 def _MergeAssets(all_assets):
   """Merges all assets from the given deps.
 
   Returns:
     A tuple of lists: (compressed, uncompressed)
     Each tuple entry is a list of "srcPath:zipPath". srcPath is the path of the
     asset to add, and zipPath is the location within the zip (excluding assets/
     prefix)
   """
@@ skipping 45 matching lines @@
       'dependencies may not write build_config files. Missing build_config '
       'files are handled differently based on the type of this target.')
 
   # android_resources options
   parser.add_option('--srcjar', help='Path to target\'s resources srcjar.')
   parser.add_option('--resources-zip', help='Path to target\'s resources zip.')
   parser.add_option('--r-text', help='Path to target\'s R.txt file.')
   parser.add_option('--package-name',
       help='Java package name for these resources.')
   parser.add_option('--android-manifest', help='Path to android manifest.')
+  parser.add_option('--is-locale-resource', action='store_true',
+                    help='Whether it is locale resource.')
 
   # android_assets options
   parser.add_option('--asset-sources', help='List of asset sources.')
   parser.add_option('--asset-renaming-sources',
                     help='List of asset sources with custom destinations.')
   parser.add_option('--asset-renaming-destinations',
                     help='List of asset custom destinations.')
   parser.add_option('--disable-asset-compression', action='store_true',
                     help='Whether to disable asset compression.')
 
@@ skipping 16 matching lines @@
   # apk options
   parser.add_option('--apk-path', help='Path to the target\'s apk output.')
 
   parser.add_option('--tested-apk-config',
       help='Path to the build config of the tested apk (for an instrumentation '
       'test apk).')
   parser.add_option('--proguard-enabled', action='store_true',
       help='Whether proguard is enabled for this apk.')
   parser.add_option('--proguard-info',
       help='Path to the proguard .info output for this apk.')
+  parser.add_option('--has-alternative-locale-resource', action='store_true',
+      help='Whether there is alternative-locale-resource in direct deps')
 
   options, args = parser.parse_args(argv)
 
   if args:
     parser.error('No positional arguments should be given.')
 
   required_options_map = {
       'java_binary': ['build_config', 'jar_path'],
       'java_library': ['build_config', 'jar_path'],
       'android_assets': ['build_config'],
@@ skipping 29 matching lines @@
   if unknown_deps and not allow_unknown_deps:
     raise Exception('Unknown deps: ' + str(unknown_deps))
 
   direct_deps_config_paths = [
       c for c in possible_deps_config_paths if not c in unknown_deps]
   direct_deps_config_paths = _FilterUnwantedDepsPaths(direct_deps_config_paths,
                                                       options.type)
 
   deps = Deps(direct_deps_config_paths)
 
+  # Remove other locale resources if there is alternative_locale_resource in
+  # direct deps.
+  if options.has_alternative_locale_resource:
+    alternative = [ r['path'] for r in deps.Direct('android_resources')

[agrieve, 2015/12/30 15:22:15]

nit: whitespace is off here. should be:
 - No space after [ nor before ]
 - "if" should align with r[

[michaelbai, 2015/12/30 19:29:48]

Done.

+                      if r.get('is_locale_resource') ]
+    # We can only have one locale resources in direct deps.
+    if len(alternative) != 1:
+      raise Exception('The number of locale resource in direct deps is wrong %d'
+                       % len(alternative))
+    unwanted = [ r['path'] for r in deps.All('android_resources')

[agrieve, 2015/12/30 15:22:14]

same here

[michaelbai, 2015/12/30 19:29:48]

Done.

+        if r.get('is_locale_resource') and r['path'] not in alternative ]
+    for p in unwanted:
+      deps.RemoveNoneDirectDep(p)
+
+
   direct_library_deps = deps.Direct('java_library')
   all_library_deps = deps.All('java_library')
 
   direct_resources_deps = deps.Direct('android_resources')
   all_resources_deps = deps.All('android_resources')
   # Resources should be ordered with the highest-level dependency first so that
   # overrides are done correctly.
   all_resources_deps.reverse()
 
   if options.type == 'android_apk' and options.tested_apk_config:
@@ skipping 77 matching lines @@
     deps_info['resources_zip'] = options.resources_zip
     if options.srcjar:
       deps_info['srcjar'] = options.srcjar
     if options.android_manifest:
       manifest = AndroidManifest(options.android_manifest)
       deps_info['package_name'] = manifest.GetPackageName()
     if options.package_name:
       deps_info['package_name'] = options.package_name
     if options.r_text:
       deps_info['r_text'] = options.r_text
+    if options.is_locale_resource:
+      deps_info['is_locale_resource'] = True
 
   if options.type in ('android_resources','android_apk', 'resource_rewriter'):
     config['resources'] = {}
     config['resources']['dependency_zips'] = [
         c['resources_zip'] for c in all_resources_deps]
     config['resources']['extra_package_names'] = []
     config['resources']['extra_r_text_files'] = []
 
   if options.type == 'android_apk' or options.type == 'resource_rewriter':
     config['resources']['extra_package_names'] = [
@@ skipping 103 matching lines @@
   build_utils.WriteJson(config, options.build_config, only_if_changed=True)
 
   if options.depfile:
     build_utils.WriteDepfile(
         options.depfile,
         deps.AllConfigPaths() + build_utils.GetPythonDependencies())
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))