Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: tools/clang/plugins/ChromeClassTester.cpp

Issue 1554533002: Mark methods with override in pdf/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add Clang plugin flag Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/plugins/ChromeClassTester.cpp
diff --git a/tools/clang/plugins/ChromeClassTester.cpp b/tools/clang/plugins/ChromeClassTester.cpp
index b39e14a0e2b08cfa8de907a4894c7af244cf1973..a6f9fff9a29a5cd34493aececbdddac0bc9c36e4 100644
--- a/tools/clang/plugins/ChromeClassTester.cpp
+++ b/tools/clang/plugins/ChromeClassTester.cpp
@@ -227,11 +227,14 @@ void ChromeClassTester::BuildBannedLists() {
allowed_directories_.emplace("/third_party/WebKit/");
}
+ if (!options_.enforce_in_pdf) {
+ banned_directories_.emplace("/pdf/");
+ }
+
banned_directories_.emplace("/third_party/");
banned_directories_.emplace("/native_client/");
banned_directories_.emplace("/breakpad/");
banned_directories_.emplace("/courgette/");
- banned_directories_.emplace("/pdf/");
banned_directories_.emplace("/ppapi/");
banned_directories_.emplace("/usr/include/");
banned_directories_.emplace("/usr/lib/");

Powered by Google App Engine
This is Rietveld 408576698