Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/clang/plugins/FindBadConstructsAction.cpp

Issue 1554533002: Mark methods with override in pdf/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add Clang plugin flag Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/ChromeClassTester.cpp ('k') | tools/clang/plugins/Options.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/FindBadConstructsAction.cpp
diff --git a/tools/clang/plugins/FindBadConstructsAction.cpp b/tools/clang/plugins/FindBadConstructsAction.cpp
index 443eecc6884a4ba9fb540ef9d585a93706bd6d55..0fb922ef2e3aead12578aa11b3ed2745550dfab3 100644
--- a/tools/clang/plugins/FindBadConstructsAction.cpp
+++ b/tools/clang/plugins/FindBadConstructsAction.cpp
@@ -49,6 +49,8 @@ bool FindBadConstructsAction::ParseArgs(const CompilerInstance& instance,
if (args[i] == "check-base-classes") {
// TODO(rsleevi): Remove this once http://crbug.com/123295 is fixed.
options_.check_base_classes = true;
+ } else if (args[i] == "enforce-in-pdf") {
+ options_.enforce_in_thirdparty_pdf = true;
Nico 2015/12/29 19:57:25 the flag is called enforce_in_pdf (no thirdparty_)
Lei Zhang 2015/12/29 20:00:17 copy + pasting is hard :(
Nico 2016/08/22 19:24:02 You never turned on this flag -- are you still pla
} else if (args[i] == "enforce-in-thirdparty-webkit") {
options_.enforce_in_thirdparty_webkit = true;
} else if (args[i] == "check-enum-last-value") {
« no previous file with comments | « tools/clang/plugins/ChromeClassTester.cpp ('k') | tools/clang/plugins/Options.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698