Issue 1554453002: Merge to XFA: Take care fall-through cases of switch in pdfium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1554453002: Merge to XFA: Take care fall-through cases of switch in pdfium (Closed)

Created:
4 years, 12 months ago by Lei Zhang

Modified:
4 years, 12 months ago

Reviewers:
tzik

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Take care fall-through cases of switch in pdfium Found with Clang's -Wimplicit-fallthrough option by tzik@chromium.org. TBR=tzik@chromium.org Review URL: https://codereview.chromium.org/1549283002 . (cherry picked from commit de0387c3690ca147482ed943c70eeb828b6dd732) Committed: https://pdfium.googlesource.com/pdfium/+/d77f03faf713c071846cf178b3cf801b230db930

Created: 4 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	fpdfsdk/src/formfiller/FFL_FormFiller.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	fpdfsdk/src/javascript/JS_GlobalData.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (1 generated)

Lei Zhang

4 years, 12 months ago (2015-12-28 21:12:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d77f03faf713c071846cf178b3cf801b230db930 (presubmit successful).