Clean up PDF plugin dependencies.

Clean up PDF plugin dependencies.

Committed: https://crrev.com/533c88e060158855b0d262b8b359c0ae75a1282c
Cr-Commit-Position: refs/heads/master@{#367413}

[Lei Zhang, 2016-01-04 22:07:30]

thestig@chromium.org changed reviewers:
+ raymes@chromium.org

[raymes, 2016-01-04 23:00:49]

lgtm but with a question

https://codereview.chromium.org/1554263004/diff/1/pdf/BUILD.gn
File pdf/BUILD.gn (right):

https://codereview.chromium.org/1554263004/diff/1/pdf/BUILD.gn#newcode44
pdf/BUILD.gn:44: if (pdf_engine == 0) {
Hmm - what is this variable used for? I only ever see it set to 0.

[Lei Zhang, 2016-01-04 23:03:03]

https://codereview.chromium.org/1554263004/diff/1/pdf/BUILD.gn
File pdf/BUILD.gn (right):

https://codereview.chromium.org/1554263004/diff/1/pdf/BUILD.gn#newcode44
pdf/BUILD.gn:44: if (pdf_engine == 0) {
On 2016/01/04 23:00:48, raymes wrote:
> Hmm - what is this variable used for? I only ever see it set to 0.

In case someone decides one day add an alternative PDF rendering engine?

[raymes, 2016-01-04 23:05:15]

On 2016/01/04 23:03:03, Lei Zhang wrote:
> https://codereview.chromium.org/1554263004/diff/1/pdf/BUILD.gn
> File pdf/BUILD.gn (right):
> 
> https://codereview.chromium.org/1554263004/diff/1/pdf/BUILD.gn#newcode44
> pdf/BUILD.gn:44: if (pdf_engine == 0) {
> On 2016/01/04 23:00:48, raymes wrote:
> > Hmm - what is this variable used for? I only ever see it set to 0.
> 
> In case someone decides one day add an alternative PDF rendering engine?

Ah ok. Is that something in progress? If not should we consider removing this
layer of indirection?

[Lei Zhang, 2016-01-04 23:05:54]

On 2016/01/04 23:03:03, Lei Zhang wrote:
> https://codereview.chromium.org/1554263004/diff/1/pdf/BUILD.gn
> File pdf/BUILD.gn (right):
> 
> https://codereview.chromium.org/1554263004/diff/1/pdf/BUILD.gn#newcode44
> pdf/BUILD.gn:44: if (pdf_engine == 0) {
> On 2016/01/04 23:00:48, raymes wrote:
> > Hmm - what is this variable used for? I only ever see it set to 0.
> 
> In case someone decides one day add an alternative PDF rendering engine?

... which I don't see happening anytime soon, but it's there and some of the
PDFEngine code is set up for this as well, so I'm inclined to just let it be.

BTW, with this CL, one can build the "pdf" target by itself much more quickly
without requiring all of third_party/WebKit via content/.

[Lei Zhang, 2016-01-04 23:06:00]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-01-04 23:07:32]

+jam to help answer questions. ^

[commit-bot: I haz the power, 2016-01-04 23:08:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1554263004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1554263004/1

[commit-bot: I haz the power, 2016-01-04 23:41:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-04 23:42:49]

Description was changed from

==========
Clean up PDF plugin dependencies.
==========

to

==========
Clean up PDF plugin dependencies.

Committed: https://crrev.com/533c88e060158855b0d262b8b359c0ae75a1282c
Cr-Commit-Position: refs/heads/master@{#367413}
==========

[commit-bot: I haz the power, 2016-01-04 23:42:50]

Patchset 1 (id:??) landed as
https://crrev.com/533c88e060158855b0d262b8b359c0ae75a1282c
Cr-Commit-Position: refs/heads/master@{#367413}