Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: pdf/BUILD.gn

Issue 1554263004: Clean up PDF plugin dependencies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pdf/pdf.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/BUILD.gn
diff --git a/pdf/BUILD.gn b/pdf/BUILD.gn
index 91bccc7a9297d1ec47ac0f787e19975ecfc194da..5582fb0145506fd20587dd4616790a734b3b8653 100644
--- a/pdf/BUILD.gn
+++ b/pdf/BUILD.gn
@@ -10,6 +10,14 @@ assert(enable_pdf)
pdf_engine = 0 # 0 PDFium
static_library("pdf") {
+ deps = [
+ "//base",
+ "//gin",
+ "//net",
+ "//ppapi/cpp:objects",
+ "//ppapi/cpp/private:internal_module",
+ ]
+
sources = [
"chunk_stream.cc",
"chunk_stream.h",
@@ -34,6 +42,8 @@ static_library("pdf") {
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
if (pdf_engine == 0) {
raymes 2016/01/04 23:00:48 Hmm - what is this variable used for? I only ever
Lei Zhang 2016/01/04 23:03:03 In case someone decides one day add an alternative
+ deps += [ "//third_party/pdfium" ]
+
sources += [
"pdfium/pdfium_api_string_buffer_adapter.cc",
"pdfium/pdfium_api_string_buffer_adapter.h",
@@ -54,15 +64,4 @@ static_library("pdf") {
if (pdf_enable_xfa) {
defines = [ "PDF_ENABLE_XFA" ]
}
-
- deps = [
- "//base",
- "//components/ui/zoom",
- "//content/public/common",
- "//gin",
- "//net",
- "//ppapi/cpp:objects",
- "//ppapi/cpp/private:internal_module",
- "//third_party/pdfium",
- ]
}
« no previous file with comments | « no previous file | pdf/pdf.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698