Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 1554233005: Don't allow inline install if frame is deleted before user accepts (Closed)

Created:
3 years, 5 months ago by asargent_no_longer_on_chrome
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Don't allow inline install if frame is deleted before user accepts If the frame that called the chrome.webstore.install method to begin an inline install gets deleted before the user accepts from the dialog, we don't want the install to continue because a navigation could make it look like the install request was coming from some unrelated site. One downside of this approach is that the dialog stays around even after the frame is deleted, and hitting either accept or cancel buttons both just cancel the install. It would be better if the dialog is automatically cancelled, but doing that would involve a lot more refactoring. The approach in this CL was easier and is probably worth getting out, and we can improve on it in the future. BUG=550047 Review URL: https://codereview.chromium.org/1403293008 Cr-Commit-Position: refs/heads/master@{#361218} (cherry picked from commit bbe84115d3dc969bfcf6ca87bebd1f5608db6ecf) Committed: https://chromium.googlesource.com/chromium/src/+/2639e878336ccd138e0ab20a3daea375998c3a81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -22 lines) Patch
M chrome/browser/extensions/tab_helper.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer.h View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer.cc View 5 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer_browsertest.cc View 4 chunks +89 lines, -8 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer_factory.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/webstore_inline_installer_factory.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/webstore_inline_install/empty.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
asargent_no_longer_on_chrome
3 years, 5 months ago (2016-01-05 21:01:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2639e878336ccd138e0ab20a3daea375998c3a81.

Powered by Google App Engine
This is Rietveld 408576698