Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1554233004: Plumb audio muting state to guest web-contents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Switch to WebContentsObserver design. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 88f58a782fd7544ae316343b06dc0b6dd50546c2..bad723e85ce4c420ef77c62662530cb748362024 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -1120,6 +1120,10 @@ void WebContentsImpl::SetAudioMuted(bool mute) {
audio_muter_->StopMuting();
}
+ // If we have guests, they should have the same audio muting state.
Charlie Reis 2016/01/06 22:13:51 If we use WebContentsObserver for this, it's gener
wjmaclean 2016/01/06 22:36:09 I included the comment to explain who the (typical
+ FOR_EACH_OBSERVER(WebContentsObserver, observers_,
+ DidUpdateAudioMutingState(mute));
+
// Notification for UI updates in response to the changed muting state.
NotifyNavigationStateChanged(INVALIDATE_TYPE_TAB);
}

Powered by Google App Engine
This is Rietveld 408576698