chrome/test/data/extensions/platform_apps/web_view/app_creates_webview/manifest.json - Issue 1554233004: Plumb audio muting state to guest web-contents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/app_creates_webview/manifest.json

Issue 1554233004: Plumb audio muting state to guest web-contents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Switch to WebContentsObserver design. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/apps/guest_view/web_view_browsertest.cc ('K') | « chrome/test/data/extensions/platform_apps/web_view/app_creates_webview/main.js ('k') | chrome/test/data/extensions/platform_apps/web_view/app_creates_webview/test.js » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/web_view/app_creates_webview/manifest.json

diff --git a/chrome/test/data/extensions/platform_apps/web_view/close_on_loadcommit/manifest.json b/chrome/test/data/extensions/platform_apps/web_view/app_creates_webview/manifest.json

similarity index 61%

copy from chrome/test/data/extensions/platform_apps/web_view/close_on_loadcommit/manifest.json

copy to chrome/test/data/extensions/platform_apps/web_view/app_creates_webview/manifest.json

index 944fa0ee6dba8080b03a0903885a64b8aa349e40..9606dccceb139c83539a9eed94ef49e2b8dd8337 100644

--- a/chrome/test/data/extensions/platform_apps/web_view/close_on_loadcommit/manifest.json

+++ b/chrome/test/data/extensions/platform_apps/web_view/app_creates_webview/manifest.json

@@ -1,5 +1,5 @@

{

- "name": "<webview> close on loadcommit",

+ "name": "<webview> test that WebContents setAudioMuting propagates to guest.",

Charlie Reis 2016/01/06 22:13:51 This test app doesn't seem specific to muting. It

wjmaclean 2016/01/06 22:36:09 True. I'll rename this to indicate it's just an ap

"version": "1",

"permissions": [

"webview"