Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1554183002: VM compiler: Remove dead strict-compare instructions in optimized code. (Closed)

Created:
4 years, 11 months ago by Florian Schneider
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM compiler: Remove dead strict-compare instructions in optimized code. Also, remove two redundant const_casts. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/413ec9682e63412015792904fe23a2d236229e9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M runtime/vm/intermediate_language.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
4 years, 11 months ago (2016-01-04 17:12:02 UTC) #2
Vyacheslav Egorov (Google)
LGTM
4 years, 11 months ago (2016-01-04 17:15:07 UTC) #4
Florian Schneider
4 years, 11 months ago (2016-01-04 17:22:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
413ec9682e63412015792904fe23a2d236229e9a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698