runtime/vm/intermediate_language.cc - Issue 1554183002: VM compiler: Remove dead strict-compare instructions in optimized code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.cc

Issue 1554183002: VM compiler: Remove dead strict-compare instructions in optimized code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language.cc

diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc

index 852efd4a97e25ab6871f391fa710625be9231282..f89e659413dab84efb6d1ba89961ec43c0f936d5 100644

--- a/runtime/vm/intermediate_language.cc

+++ b/runtime/vm/intermediate_language.cc

@@ -2522,6 +2522,7 @@ Instruction* BranchInstr::Canonicalize(FlowGraph* flow_graph) {

Definition* StrictCompareInstr::Canonicalize(FlowGraph* flow_graph) {

+ if (!HasUses()) return NULL;

bool negated = false;

Definition* replacement = CanonicalizeStrictCompare(this, &negated);

if (negated && replacement->IsComparison()) {

« no previous file with comments | « no previous file | runtime/vm/parser.cc » ('j') | no next file with comments »