null namespace check - fixes #25331

null namespace check - fixes #25331

Committed: https://github.com/dart-lang/sdk/commit/465bae9b8ceff663296674acc5350df04e50f162

[danrubel, 2016-01-04 15:43:01]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-01-04 16:59:55]

I'm a little concerned that this will just mask a deeper problem. Is it really
reasonable for the namespace to be `null` when we get to this method?

[danrubel, 2016-01-04 17:32:08]

On 2016/01/04 16:59:55, Brian Wilkerson wrote:
> I'm a little concerned that this will just mask a deeper problem. Is it really
> reasonable for the namespace to be `null` when we get to this method?

Really good question. I don't have a repro case for this. We should be resolving
all imports via resolveDirectives(1) if in a part file or indirectly when
building the DartCompletionRequest. There could be a race condition between when
the request is built, user typing, and when the resolved directives are needed.
Barring a good test case, I could be more defensive in resolveDirectives and
always request they be resolved rather than relying them already being resolved,
remove the null check, and wait to see if it fixes the problem in the wild. 

PTAL and let me know how I should proceed.

(1) resolveDirectives -
(https://github.com/dart-lang/sdk/blob/master/pkg/analysis_server/lib/src/serv...).

[Brian Wilkerson, 2016-01-07 16:37:32]

As per our conversation, I agree that re-requesting the data you need, rather
than assuming it will still be in the cache, is the right solution.

[danrubel, 2016-01-07 19:25:13]

On 2016/01/07 16:37:32, Brian Wilkerson wrote:
> As per our conversation, I agree that re-requesting the data you need, rather
> than assuming it will still be in the cache, is the right solution.

Updated CL. PTAL.

[danrubel, 2016-01-08 20:54:19]

Description was changed from

==========
null namespace check - fixes #25331
==========

to

==========
null namespace check - fixes #25331

Committed:
https://github.com/dart-lang/sdk/commit/465bae9b8ceff663296674acc5350df04e50f162
==========

[danrubel, 2016-01-08 20:54:20]

Committed patchset #4 (id:60001) manually as
465bae9b8ceff663296674acc5350df04e50f162 (presubmit successful).