pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart - Issue 1554153002: null namespace check - fixes #25331

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

Issue 1554153002: null namespace check - fixes #25331 (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: merge Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

index cfe0ca7993c46599bca6d5fffa7011e05624c5c7..602503e789842eda3251958ee1ae8fc44ce2fbc3 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

@@ -204,9 +204,7 @@ class DartCompletionRequestImpl implements DartCompletionRequest {

@override

Future<List<Directive>> resolveDirectives() async {

CompilationUnit libUnit;

- if (librarySource == source) {

- libUnit = target.unit;

- } else if (librarySource != null) {

+ if (librarySource != null) {

// TODO(danrubel) only resolve the directives

const RESOLVE_DIRECTIVES_TAG = 'resolve directives';

performance.logStartTime(RESOLVE_DIRECTIVES_TAG);

« no previous file with comments | « no previous file | no next file » | no next file with comments »