Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Issue 155404: Fixed bug where playbackRate wasn't being respected. (Closed)

Created:
11 years, 5 months ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fixed bug where playbackRate wasn't being respected. BUG=16502 TEST=setting defaultPlaybackRate before the media starts playing should be respected when play() is called

Patch Set 1 #

Patch Set 2 : Uploaded too much #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M webkit/glue/webmediaplayer_impl.h View 1 chunk +9 lines, -0 lines 0 comments Download
M webkit/glue/webmediaplayer_impl.cc View 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scherkus (not reviewing)
11 years, 5 months ago (2009-07-11 02:15:53 UTC) #1
scherkus (not reviewing)
ping
11 years, 5 months ago (2009-07-13 20:16:39 UTC) #2
Alpha Left Google
11 years, 5 months ago (2009-07-14 19:15:30 UTC) #3
Sadly this is something necessary to be done as we wanted to keep pipeline
simple and only has playback rate for controling playback..

LGTM.

Powered by Google App Engine
This is Rietveld 408576698