Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: webkit/glue/webmediaplayer_impl.h

Issue 155404: Fixed bug where playbackRate wasn't being respected. (Closed)
Patch Set: Uploaded too much Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webkit/glue/webmediaplayer_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2008-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2008-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be found 2 // Use of this source code is governed by a BSD-style license that can be found
3 // in the LICENSE file. 3 // in the LICENSE file.
4 // 4 //
5 // Delegate calls from WebCore::MediaPlayerPrivate to Chrome's video player. 5 // Delegate calls from WebCore::MediaPlayerPrivate to Chrome's video player.
6 // It contains PipelineImpl which is the actual media player pipeline, it glues 6 // It contains PipelineImpl which is the actual media player pipeline, it glues
7 // the media player pipeline, data source, audio renderer and renderer. 7 // the media player pipeline, data source, audio renderer and renderer.
8 // PipelineImpl would creates multiple threads and access some public methods 8 // PipelineImpl would creates multiple threads and access some public methods
9 // of this class, so we need to be extra careful about concurrent access of 9 // of this class, so we need to be extra careful about concurrent access of
10 // methods and members. 10 // methods and members.
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 // for DCHECKs so methods calls won't execute in the wrong thread. 245 // for DCHECKs so methods calls won't execute in the wrong thread.
246 MessageLoop* main_loop_; 246 MessageLoop* main_loop_;
247 247
248 // A collection of factories for creating filters. 248 // A collection of factories for creating filters.
249 scoped_refptr<media::FilterFactoryCollection> filter_factory_; 249 scoped_refptr<media::FilterFactoryCollection> filter_factory_;
250 250
251 // The actual pipeline and the thread it runs on. 251 // The actual pipeline and the thread it runs on.
252 scoped_ptr<media::PipelineImpl> pipeline_; 252 scoped_ptr<media::PipelineImpl> pipeline_;
253 base::Thread pipeline_thread_; 253 base::Thread pipeline_thread_;
254 254
255 // Playback state.
256 //
257 // TODO(scherkus): we have these because Pipeline favours the simplicity of a
258 // single "playback rate" over worrying about paused/stopped etc... It forces
259 // all clients to manage the pause+playback rate externally, but is that
260 // really a bad thing?
261 bool paused_;
262 float playback_rate_;
263
255 WebKit::WebMediaPlayerClient* client_; 264 WebKit::WebMediaPlayerClient* client_;
256 265
257 scoped_refptr<Proxy> proxy_; 266 scoped_refptr<Proxy> proxy_;
258 267
259 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl); 268 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl);
260 }; 269 };
261 270
262 } // namespace webkit_glue 271 } // namespace webkit_glue
263 272
264 #endif // WEBKIT_GLUE_WEBMEDIAPLAYER_IMPL_H_ 273 #endif // WEBKIT_GLUE_WEBMEDIAPLAYER_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | webkit/glue/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698