Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1553963002: Try to let gles2_conform tests build with -Wall. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
Geoff Lang, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try to let gles2_conform tests build with -Wall. This is a bit difficult since these tests have no trybots and can only be tested locally with a src-internal checkout, which I currently don't have access to. BUG=573250, 573608 R=geofflang@chromium.org TBR=piman Committed: https://chromium.googlesource.com/chromium/src/+/72b857512da7f6b67cc7f303c552f7371965bf47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M gpu/gles2_conform_support/gles2_conform_test.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Nico
tbr piman for gpu owners
4 years, 11 months ago (2016-01-01 23:27:57 UTC) #3
Geoff Lang
LGTM
4 years, 11 months ago (2016-01-01 23:28:18 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/72b857512da7f6b67cc7f303c552f7371965bf47 Cr-Commit-Position: refs/heads/master@{#367270}
4 years, 11 months ago (2016-01-01 23:35:11 UTC) #7
Nico
4 years, 11 months ago (2016-01-01 23:35:51 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
72b857512da7f6b67cc7f303c552f7371965bf47.

Powered by Google App Engine
This is Rietveld 408576698