Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1553943002: Revert of mac and ios: Build third-party code with -Wall. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac and ios: Build third-party code with -Wall. (patchset #1 id:1 of https://codereview.chromium.org/1555843002/ ) Reason for revert: ios_Device builder isn't quite ready for -Wall, http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/33368 breaking compilation. Original issue's description: > mac and ios: Build third-party code with -Wall. > > This lands the mac and ios build/common.gypi bits of > https://codereview.chromium.org/1551753002/ (reviewed there) > > BUG=573250 > R=thestig@chromium.org > TBR=thestig@chromium.org > > Committed: https://crrev.com/9830789346abd3d8211deff1ebe7a7f5753ba3fc > Cr-Commit-Position: refs/heads/master@{#367255} TBR=thestig@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=573250 Committed: https://crrev.com/02b240dbc9219e8ae755dd99ded199ac7b4bf77f Cr-Commit-Position: refs/heads/master@{#367258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Created Revert of mac and ios: Build third-party code with -Wall.
4 years, 11 months ago (2016-01-01 06:16:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553943002/1
4 years, 11 months ago (2016-01-01 06:17:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-01 06:18:05 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-01 06:19:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02b240dbc9219e8ae755dd99ded199ac7b4bf77f
Cr-Commit-Position: refs/heads/master@{#367258}

Powered by Google App Engine
This is Rietveld 408576698