build/common.gypi - Issue 1553943002: Revert of mac and ios: Build third-party code with -Wall.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1553943002: Revert of mac and ios: Build third-party code with -Wall. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index d6293212deb0bf6584f6d4867d9c5ffadadf0364..c3bc3dff43c892f8930db4e60954bdfab835a581 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -3210,7 +3210,7 @@

[ 'OS=="mac" or OS=="ios"', {

'xcode_settings': {

- 'WARNING_CFLAGS!': ['-Wextra'],

+ 'WARNING_CFLAGS!': ['-Wall', '-Wextra'],

'conditions': [

['buildtype=="Official"', {

« no previous file with comments | « no previous file | no next file » | no next file with comments »