Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 155378: Replace ShowAsPopupWithItems to CreatePopupWidgetWithInfo. Also,... (Closed)

Created:
11 years, 5 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
Paul Godavari
CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), brettw, Ben Goodger (Google)
Visibility:
Public.

Description

Replace ShowAsPopupWithItems to CreatePopupWidgetWithInfo. Also, make use of WebPopupMenuInfo from the WebKit API. WebMenuItem remains in webkit/glue for convenience with IPC marshalling and related usage in Chrome. This work is precursor to switching over to using WebWidget from the WebKit API. BUG=16234 TEST=html select drop downs should still work on the mac. try switching languages on news.google.com. R=paul Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20624

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 2

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -202 lines) Patch
M chrome/browser/renderer_host/render_widget_host.h View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 1 2 3 4 5 6 4 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/render_messages.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/print_web_view_helper.h View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/renderer/render_view.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 2 3 4 5 6 7 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/renderer/render_widget.h View 1 2 3 4 5 6 5 chunks +12 lines, -5 lines 0 comments Download
M chrome/renderer/render_widget.cc View 1 2 3 4 5 6 4 chunks +17 lines, -16 lines 0 comments Download
M webkit/api/public/WebPopupMenuInfo.h View 1 2 3 4 5 6 4 chunks +6 lines, -6 lines 0 comments Download
M webkit/glue/chrome_client_impl.h View 1 2 3 4 5 6 3 chunks +5 lines, -4 lines 0 comments Download
M webkit/glue/chrome_client_impl.cc View 1 2 3 4 5 6 7 4 chunks +50 lines, -51 lines 0 comments Download
A webkit/glue/webmenuitem.h View 1 1 chunk +33 lines, -0 lines 0 comments Download
M webkit/glue/webmenurunner_mac.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webmenurunner_mac.mm View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webview_delegate.h View 1 2 3 4 5 6 7 2 chunks +9 lines, -0 lines 0 comments Download
M webkit/glue/webwidget_delegate.h View 1 2 3 4 5 6 2 chunks +0 lines, -31 lines 0 comments Download
M webkit/glue/webwidget_impl.h View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/glue/webwidget_impl.cc View 1 2 3 4 5 6 1 chunk +0 lines, -14 lines 0 comments Download
M webkit/glue/webworker_impl.cc View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/mac/test_webview_delegate.mm View 1 2 3 4 5 6 7 5 chunks +26 lines, -12 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 2 3 4 5 6 7 5 chunks +21 lines, -11 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_gtk.cc View 6 1 chunk +0 lines, -9 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_win.cc View 6 1 chunk +0 lines, -9 lines 0 comments Download
M webkit/webkit.gyp View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
darin (slow to review)
11 years, 5 months ago (2009-07-10 21:10:49 UTC) #1
Paul Godavari
Very nice clean up, LGTM: http://codereview.chromium.org/155378/diff/183/191 File webkit/glue/webview_delegate.h (right): http://codereview.chromium.org/155378/diff/183/191#newcode127 Line 127: bool activatable, 'activatable' ...
11 years, 5 months ago (2009-07-13 21:20:14 UTC) #2
darin (slow to review)
11 years, 5 months ago (2009-07-13 23:15:16 UTC) #3 
http://codereview.chromium.org/155378/diff/183/191
File webkit/glue/webview_delegate.h (right):

http://codereview.chromium.org/155378/diff/183/191#newcode127
Line 127: bool activatable,
OK... hmm, I only kept it there for symmetry with CreatePopupWidget.  I guess
since it is not needed, I should just remove it though.

Powered by Google App Engine
This is Rietveld 408576698