Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8675)

Unified Diff: chrome/browser/renderer_host/render_widget_host.cc

Issue 155378: Replace ShowAsPopupWithItems to CreatePopupWidgetWithInfo. Also,... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/render_widget_host.cc
===================================================================
--- chrome/browser/renderer_host/render_widget_host.cc (revision 20609)
+++ chrome/browser/renderer_host/render_widget_host.cc (working copy)
@@ -135,7 +135,7 @@
IPC_MESSAGE_HANDLER(ViewHostMsg_DestroyPluginContainer,
OnMsgDestroyPluginContainer)
#elif defined(OS_MACOSX)
- IPC_MESSAGE_HANDLER_GENERIC(ViewHostMsg_ShowPopup, OnMsgShowPopup(msg))
+ IPC_MESSAGE_HANDLER(ViewHostMsg_ShowPopup, OnMsgShowPopup)
IPC_MESSAGE_HANDLER(ViewHostMsg_GetScreenInfo, OnMsgGetScreenInfo)
IPC_MESSAGE_HANDLER(ViewHostMsg_GetWindowRect, OnMsgGetWindowRect)
IPC_MESSAGE_HANDLER(ViewHostMsg_GetRootWindowRect, OnMsgGetRootWindowRect)
@@ -752,6 +752,7 @@
}
#if defined(OS_LINUX)
+
void RenderWidgetHost::OnMsgCreatePluginContainer(
gfx::PluginWindowHandle *container) {
*container = view_->CreatePluginContainer();
@@ -761,18 +762,15 @@
gfx::PluginWindowHandle container) {
view_->DestroyPluginContainer(container);
}
+
#elif defined(OS_MACOSX)
-void RenderWidgetHost::OnMsgShowPopup(const IPC::Message& message) {
- void* iter = NULL;
- ViewHostMsg_ShowPopup_Params validated_params;
- if (!IPC::ParamTraits<ViewHostMsg_ShowPopup_Params>::Read(&message, &iter,
- &validated_params))
- return;
- view_->ShowPopupWithItems(validated_params.bounds,
- validated_params.item_height,
- validated_params.selected_item,
- validated_params.popup_items);
+void RenderWidgetHost::OnMsgShowPopup(
+ const ViewHostMsg_ShowPopup_Params& params) {
+ view_->ShowPopupWithItems(params.bounds,
+ params.item_height,
+ params.selected_item,
+ params.popup_items);
}
void RenderWidgetHost::OnMsgGetScreenInfo(gfx::NativeViewId view,
@@ -794,6 +792,7 @@
*results = view_->GetRootWindowRect();
}
}
+
#endif
void RenderWidgetHost::PaintBackingStoreRect(TransportDIB* bitmap,
« no previous file with comments | « chrome/browser/renderer_host/render_widget_host.h ('k') | chrome/browser/renderer_host/render_widget_host_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698