Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1553743002: change factory to method, to parallel pattern in imagefilters (Closed)

Created:
4 years, 11 months ago by reed2
Modified:
4 years, 11 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

change factory to method, to parallel pattern in imagefilters. no functionality change. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1553743002 TBR= Committed: https://skia.googlesource.com/skia/+/f880e45e92fe612bafbf745da96e209220cee8da

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -26 lines) Patch
M gm/perlinnoise.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkShader.h View 1 2 chunks +10 lines, -9 lines 0 comments Download
M samplecode/SamplePatch.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkLocalMatrixShader.cpp View 2 chunks +10 lines, -13 lines 0 comments Download
M src/effects/SkRectShaderImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553743002/20001
4 years, 11 months ago (2015-12-30 21:24:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553743002/20001
4 years, 11 months ago (2015-12-30 21:29:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/f880e45e92fe612bafbf745da96e209220cee8da
4 years, 11 months ago (2015-12-30 21:39:45 UTC) #10
mtklein
4 years, 11 months ago (2015-12-30 21:52:18 UTC) #11
Message was sent while issue was closed.
On 2015/12/30 21:39:45, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
> https://skia.googlesource.com/skia/+/f880e45e92fe612bafbf745da96e209220cee8da

I think you may need to do some Android hacking, in Shader.cpp's
Shader_setLocalMatrix()?

Powered by Google App Engine
This is Rietveld 408576698