Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: include/core/SkShader.h

Issue 1553743002: change factory to method, to parallel pattern in imagefilters (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gm/perlinnoise.cpp ('k') | samplecode/SamplePatch.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkShader.h
diff --git a/include/core/SkShader.h b/include/core/SkShader.h
index 9b48697d20ae4e673951dfb351cba7a714782abb..97160a4f2511f909d2c8adc0f8ed3484287d22ac 100644
--- a/include/core/SkShader.h
+++ b/include/core/SkShader.h
@@ -346,9 +346,18 @@ public:
#endif
//////////////////////////////////////////////////////////////////////////
- // Factory methods for stock shaders
+ // Methods to create combinations or variants of shaders
/**
+ * Return a shader that will apply the specified localMatrix to this shader.
+ * The specified matrix will be applied before any matrix associated with this shader.
+ */
+ SkShader* newWithLocalMatrix(const SkMatrix&) const;
+
+ //////////////////////////////////////////////////////////////////////////
+ // Factory methods for stock shaders
+
+ /**
* Call this to create a new "empty" shader, that will not draw anything.
*/
static SkShader* CreateEmptyShader();
@@ -399,14 +408,6 @@ public:
const SkRect* tile);
/**
- * Return a shader that will apply the specified localMatrix to the proxy shader.
- * The specified matrix will be applied before any matrix associated with the proxy.
- *
- * Note: ownership of the proxy is not transferred (though a ref is taken).
- */
- static SkShader* CreateLocalMatrixShader(SkShader* proxy, const SkMatrix& localMatrix);
-
- /**
* If this shader can be represented by another shader + a localMatrix, return that shader
* and, if not NULL, the localMatrix. If not, return NULL and ignore the localMatrix parameter.
*
« no previous file with comments | « gm/perlinnoise.cpp ('k') | samplecode/SamplePatch.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698