rm notification about lack of Google Play Services

rm notification about lack of Google Play Services

Chromium works fine without Google Play Services, so the notification
isn't correct. It's also a generic Android system notification so it
doesn't actually tell the user which functionality is unavailable. It
triggers as soon as Chromium is launched and remains present until it's
dismissed by the user, only to reappear when it's launched again.

It would make sense to either hide the functionality that's not going to
work or show an error dialog if the user tries to use it but there's no
reason to always have a notification about the lack of Google Play.

BUG=569285
R=klobag@chromium.org

[strcat, 2015-12-30 15:04:33]

If you're curious about the context, I use Chromium as a replacement for the
obsolete AOSP browser in CopperheadOS (https://copperhead.co/android/). The
intention is for the ROM to be completely usable without Play Services so the
notification really can't be present. It would also be nice to see Chromium in
the primary F-Droid repository (https://f-droid.org/).

[Ian Wen, 2016-01-04 03:55:30]

ianwen@chromium.org changed reviewers:
+ ianwen@chromium.org, knn@chromium.org, nyquist@chromium.org
- klobag@chromium.org

[Ian Wen, 2016-01-04 03:55:31]

Remove klobag@ and add correct reviewers.

Showing a system bar is indeed not a very useful UX, especially on AOSP.

https://codereview.chromium.org/1553713002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountIdProvider.java
(right):

https://codereview.chromium.org/1553713002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountIdProvider.java:60:
* the user to update Google Play services, else a System notification is shown.
You should update this javadoc as well.

[knn, 2016-01-04 13:02:01]

Thanks Daniel for catching this!

I had originally added this notification only if the user tries to signin but
the scope of the notification has increased since
https://codereview.chromium.org/1256283002
More changes are required to achieve the original behaviour properly so I took
the liberty of writing a change here
(https://codereview.chromium.org/1554103002).
I appreciate the effort you put to write the patch!