Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1554103002: Notify the lack of Google Play Services only if the user tries to Signin. (Closed)

Created:
2 years, 5 months ago by knn
Modified:
2 years, 5 months ago
Reviewers:
nyquist
CC:
chromium-reviews, strcat
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notify the lack of Google Play Services only if the user tries to Signin. We do not show the annoying play services missing notification unless it is actually required as a result of some action taken by the user like signin. BUG=569285 Committed: https://crrev.com/7cf072a34e50d8cee9730f7d596c9a6f0a5cec8c Cr-Commit-Position: refs/heads/master@{#367819}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix test #

Messages

Total messages: 21 (10 generated)
knn
PTAL. Thanks!
2 years, 5 months ago (2016-01-04 13:04:40 UTC) #2
nyquist
lgtm
2 years, 5 months ago (2016-01-05 21:38:32 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554103002/1
2 years, 5 months ago (2016-01-06 03:41:18 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/113214) ios_rel_device_ninja on ...
2 years, 5 months ago (2016-01-06 03:43:19 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554103002/20001
2 years, 5 months ago (2016-01-06 05:26:36 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/4655)
2 years, 5 months ago (2016-01-06 07:17:38 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554103002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554103002/40001
2 years, 5 months ago (2016-01-06 11:19:04 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
2 years, 5 months ago (2016-01-06 11:59:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554103002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554103002/40001
2 years, 5 months ago (2016-01-06 14:10:06 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
2 years, 5 months ago (2016-01-06 14:14:10 UTC) #19
commit-bot: I haz the power
2 years, 5 months ago (2016-01-06 14:14:54 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7cf072a34e50d8cee9730f7d596c9a6f0a5cec8c
Cr-Commit-Position: refs/heads/master@{#367819}

Powered by Google App Engine
This is Rietveld 408576698