[runtime] TailCallRuntime and CallRuntime should use default argument counts

[runtime] TailCallRuntime and CallRuntime should use default argument
counts specified in runtime.h.

In the vast majority of the cases when we call into the runtime we use
the default number of arguments. Hence, there is not need to specify it
again. This CL also removes TailCallExternalReference as there were no
users.

BUG=

Committed: https://crrev.com/b889d79de1e9af4719228536c736351c5680f25e
Cr-Commit-Position: refs/heads/master@{#33066}

[Camillo Bruni, 2015-12-30 13:10:29]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-30 13:10:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553703002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553703002/1

[Camillo Bruni, 2015-12-30 13:31:46]

cbruni@chromium.org changed reviewers:
+ ishell@chromium.org

[Camillo Bruni, 2015-12-30 13:31:47]

PTAL
sorry for the long CL :(

https://codereview.chromium.org/1553703002/diff/1/src/ic/arm/ic-arm.cc
File src/ic/arm/ic-arm.cc (left):

https://codereview.chromium.org/1553703002/diff/1/src/ic/arm/ic-arm.cc#oldcod...
src/ic/arm/ic-arm.cc:313: __ TailCallRuntime(Runtime::kLoadIC_Miss, arg_count);
for some of the IC runtime functions I had to update the default arg count.

https://codereview.chromium.org/1553703002/diff/1/src/runtime/runtime.h
File src/runtime/runtime.h (left):

https://codereview.chromium.org/1553703002/diff/1/src/runtime/runtime.h#oldco...
src/runtime/runtime.h:1052: F(LoadIC_MissFromStubFailure, 0, 1)
Updated some default argument counts + sorted the list (sorry for that).

[Camillo Bruni, 2015-12-30 13:32:47]

Description was changed from

==========
[runtime] TailCallRuntime and CallRuntime should use argument counts
specified in runtime.h.

In the vast majority of the cases when we call into the runtime we use
the default number of arguments. Hence, there is not need to specify this
again.


BUG=
==========

to

==========
[runtime] TailCallRuntime and CallRuntime should use argument counts
specified in runtime.h.

In the vast majority of the cases when we call into the runtime we use
the default number of arguments. Hence, there is not need to specify this
again. This CL also removes TailCallExternalReference as there were no
users.


BUG=
==========

[commit-bot: I haz the power, 2015-12-30 13:39:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-30 13:39:53]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2015-12-30 14:48:18]

lgtm with nits:

https://codereview.chromium.org/1553703002/diff/1/src/ia32/macro-assembler-ia...
File src/ia32/macro-assembler-ia32.cc (right):

https://codereview.chromium.org/1553703002/diff/1/src/ia32/macro-assembler-ia...
src/ia32/macro-assembler-ia32.cc:1904: // ----------- S t a t e -------------
Probably we don't need this comment here as all the other platforms also do not
have it.

https://codereview.chromium.org/1553703002/diff/1/src/ic/arm/handler-compiler...
File src/ic/arm/handler-compiler-arm.cc (right):

https://codereview.chromium.org/1553703002/diff/1/src/ic/arm/handler-compiler...
src/ic/arm/handler-compiler-arm.cc:225:
DCHECK(NamedLoadHandlerCompiler::kInterceptorArgsLength ==
DCHECK_EQ

https://codereview.chromium.org/1553703002/diff/1/src/ic/arm64/handler-compil...
File src/ic/arm64/handler-compiler-arm64.cc (right):

https://codereview.chromium.org/1553703002/diff/1/src/ic/arm64/handler-compil...
src/ic/arm64/handler-compiler-arm64.cc:133:
DCHECK(NamedLoadHandlerCompiler::kInterceptorArgsLength ==
Ditto.

https://codereview.chromium.org/1553703002/diff/1/src/ic/ia32/handler-compile...
File src/ic/ia32/handler-compiler-ia32.cc (right):

https://codereview.chromium.org/1553703002/diff/1/src/ic/ia32/handler-compile...
src/ic/ia32/handler-compiler-ia32.cc:300:
DCHECK(NamedLoadHandlerCompiler::kInterceptorArgsLength ==
Ditto.

https://codereview.chromium.org/1553703002/diff/1/src/ic/mips/handler-compile...
File src/ic/mips/handler-compiler-mips.cc (right):

https://codereview.chromium.org/1553703002/diff/1/src/ic/mips/handler-compile...
src/ic/mips/handler-compiler-mips.cc:218:
DCHECK(NamedLoadHandlerCompiler::kInterceptorArgsLength ==
Ditto.

https://codereview.chromium.org/1553703002/diff/1/src/ic/ppc/handler-compiler...
File src/ic/ppc/handler-compiler-ppc.cc (right):

https://codereview.chromium.org/1553703002/diff/1/src/ic/ppc/handler-compiler...
src/ic/ppc/handler-compiler-ppc.cc:223:
DCHECK(NamedLoadHandlerCompiler::kInterceptorArgsLength ==
Ditto.

https://codereview.chromium.org/1553703002/diff/1/src/ic/x64/handler-compiler...
File src/ic/x64/handler-compiler-x64.cc (right):

https://codereview.chromium.org/1553703002/diff/1/src/ic/x64/handler-compiler...
src/ic/x64/handler-compiler-x64.cc:115:
DCHECK(NamedLoadHandlerCompiler::kInterceptorArgsLength ==
Ditto.

https://codereview.chromium.org/1553703002/diff/1/src/ic/x87/handler-compiler...
File src/ic/x87/handler-compiler-x87.cc (right):

https://codereview.chromium.org/1553703002/diff/1/src/ic/x87/handler-compiler...
src/ic/x87/handler-compiler-x87.cc:300:
DCHECK(NamedLoadHandlerCompiler::kInterceptorArgsLength ==
Ditto.

https://codereview.chromium.org/1553703002/diff/1/src/mips/macro-assembler-mi...
File src/mips/macro-assembler-mips.cc (right):

https://codereview.chromium.org/1553703002/diff/1/src/mips/macro-assembler-mi...
src/mips/macro-assembler-mips.cc:4527: if (function->nargs >= 0) {
The TODO comment seems to be still relevant. Please put it back.

https://codereview.chromium.org/1553703002/diff/1/src/mips64/macro-assembler-...
File src/mips64/macro-assembler-mips64.cc (right):

https://codereview.chromium.org/1553703002/diff/1/src/mips64/macro-assembler-...
src/mips64/macro-assembler-mips64.cc:5060: if (function->nargs >= 0) {
Ditto.

https://codereview.chromium.org/1553703002/diff/1/src/ppc/macro-assembler-ppc.cc
File src/ppc/macro-assembler-ppc.cc (right):

https://codereview.chromium.org/1553703002/diff/1/src/ppc/macro-assembler-ppc...
src/ppc/macro-assembler-ppc.cc:2318: if (function->nargs >= 0) {
Ditto.

https://codereview.chromium.org/1553703002/diff/1/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):

https://codereview.chromium.org/1553703002/diff/1/src/x64/macro-assembler-x64...
src/x64/macro-assembler-x64.cc:678: if (function->nargs >= 0) {
Ditto.

[Camillo Bruni, 2015-12-30 15:43:58]

Description was changed from

==========
[runtime] TailCallRuntime and CallRuntime should use argument counts
specified in runtime.h.

In the vast majority of the cases when we call into the runtime we use
the default number of arguments. Hence, there is not need to specify this
again. This CL also removes TailCallExternalReference as there were no
users.


BUG=
==========

to

==========
[runtime] TailCallRuntime and CallRuntime should use argument counts
specified in runtime.h.

In the vast majority of the cases when we call into the runtime we use
the default number of arguments. Hence, there is not need to specify this
again. This CL also removes TailCallExternalReference as there were no
users.

BUG=
==========

[Camillo Bruni, 2015-12-30 15:44:02]

The CQ bit was checked by cbruni@chromium.org

[commit-bot: I haz the power, 2015-12-30 15:44:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553703002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553703002/1

[commit-bot: I haz the power, 2015-12-30 15:48:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-30 15:48:55]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9339)

[Camillo Bruni, 2015-12-30 16:19:57]

cbruni@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Camillo Bruni, 2015-12-30 16:19:58]

bmeurer: please take a look at the changes in crankshaft/*

[Benedikt Meurer, 2015-12-30 18:07:22]

LGTM on crankshaft.

[Camillo Bruni, 2015-12-30 20:46:46]

Description was changed from

==========
[runtime] TailCallRuntime and CallRuntime should use argument counts
specified in runtime.h.

In the vast majority of the cases when we call into the runtime we use
the default number of arguments. Hence, there is not need to specify this
again. This CL also removes TailCallExternalReference as there were no
users.

BUG=
==========

to

==========
[runtime] TailCallRuntime and CallRuntime should use default argument
counts specified in runtime.h.

In the vast majority of the cases when we call into the runtime we use
the default number of arguments. Hence, there is not need to specify it
again. This CL also removes TailCallExternalReference as there were no
users.

BUG=
==========

[Camillo Bruni, 2015-12-30 20:46:56]

The CQ bit was checked by cbruni@chromium.org

[commit-bot: I haz the power, 2015-12-30 20:47:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553703002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553703002/1

[commit-bot: I haz the power, 2015-12-30 20:50:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-30 20:51:11]

Description was changed from

==========
[runtime] TailCallRuntime and CallRuntime should use default argument
counts specified in runtime.h.

In the vast majority of the cases when we call into the runtime we use
the default number of arguments. Hence, there is not need to specify it
again. This CL also removes TailCallExternalReference as there were no
users.

BUG=
==========

to

==========
[runtime] TailCallRuntime and CallRuntime should use default argument
counts specified in runtime.h.

In the vast majority of the cases when we call into the runtime we use
the default number of arguments. Hence, there is not need to specify it
again. This CL also removes TailCallExternalReference as there were no
users.

BUG=

Committed: https://crrev.com/b889d79de1e9af4719228536c736351c5680f25e
Cr-Commit-Position: refs/heads/master@{#33066}
==========

[commit-bot: I haz the power, 2015-12-30 20:51:12]

Patchset 1 (id:??) landed as
https://crrev.com/b889d79de1e9af4719228536c736351c5680f25e
Cr-Commit-Position: refs/heads/master@{#33066}