Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1550923002: Remove uses of result size in TailCallRuntime and friends (Closed)

Created:
4 years, 11 months ago by Camillo Bruni
Modified:
4 years, 11 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove uses of result_size in TailCallRuntime and friends JumpToExternalReference ignored the passed-in result_size argument, which defaulted to 1. This change updates all users to not use a result_size. BUG= Committed: https://crrev.com/b24fc481344f34f371b78981a7186528214d3899 Cr-Commit-Position: refs/heads/master@{#33059}

Patch Set 1 #

Patch Set 2 : dude, if I see one more 1 #

Total comments: 3

Patch Set 3 : change spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+435 lines, -494 lines) Patch
M src/arm/builtins-arm.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 26 chunks +29 lines, -30 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 25 chunks +29 lines, -30 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/builtins.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 26 chunks +29 lines, -30 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/ic/arm/ic-compiler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 6 chunks +6 lines, -7 lines 0 comments Download
M src/ic/arm64/ic-compiler-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/ic/ia32/ic-compiler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ia32/ic-ia32.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M src/ic/mips/ic-compiler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips/ic-mips.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/ic/mips64/ic-compiler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips64/ic-mips64.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/ic/ppc/ic-compiler-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ppc/ic-ppc.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/ic/x64/ic-compiler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/x64/ic-x64.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M src/ic/x87/ic-compiler-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/x87/ic-x87.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/mips/builtins-mips.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 26 chunks +29 lines, -30 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 26 chunks +29 lines, -30 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 2 26 chunks +29 lines, -30 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/x64/builtins-x64.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 25 chunks +30 lines, -32 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +3 lines, -6 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +6 lines, -11 lines 0 comments Download
M src/x87/builtins-x87.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 2 26 chunks +29 lines, -30 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 2 chunks +3 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550923002/20001
4 years, 11 months ago (2015-12-29 15:03:15 UTC) #2
Camillo Bruni
PTAL
4 years, 11 months ago (2015-12-29 15:10:05 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-29 15:29:58 UTC) #7
Igor Sheludko
lgtm with nits: https://codereview.chromium.org/1550923002/diff/20001/src/ppc/code-stubs-ppc.cc File src/ppc/code-stubs-ppc.cc (right): https://codereview.chromium.org/1550923002/diff/20001/src/ppc/code-stubs-ppc.cc#newcode725 src/ppc/code-stubs-ppc.cc:725: __TailCallRuntime( Spurious change: deleted space after ...
4 years, 11 months ago (2015-12-29 15:51:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1550923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1550923002/40001
4 years, 11 months ago (2015-12-29 17:00:06 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2015-12-29 17:19:52 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 17:20:29 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b24fc481344f34f371b78981a7186528214d3899
Cr-Commit-Position: refs/heads/master@{#33059}

Powered by Google App Engine
This is Rietveld 408576698