Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1553643002: Unify some platform-specific methods for PrintWebViewHelper. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@printcros
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify some platform-specific methods for PrintWebViewHelper. On Linux/Android/Windows, use somewhat shared implementations of: - CopyMetafileDataToSharedMem() - PrintPagesInternal() - RenderPreviewPage() Committed: https://crrev.com/8dc97779e959b954c4784eceeaee62b11ee909e4 Cr-Commit-Position: refs/heads/master@{#369539}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : rebase #

Total comments: 3

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -220 lines) Patch
M components/printing/renderer/print_web_view_helper.h View 1 1 chunk +4 lines, -8 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 1 2 3 4 5 chunks +127 lines, -2 lines 0 comments Download
M components/printing/renderer/print_web_view_helper_linux.cc View 4 chunks +1 line, -80 lines 0 comments Download
M components/printing/renderer/print_web_view_helper_pdf_win.cc View 2 chunks +0 lines, -130 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Lei Zhang
https://codereview.chromium.org/1553643002/diff/60001/components/printing/renderer/print_web_view_helper_linux.cc File components/printing/renderer/print_web_view_helper_linux.cc (left): https://codereview.chromium.org/1553643002/diff/60001/components/printing/renderer/print_web_view_helper_linux.cc#oldcode146 components/printing/renderer/print_web_view_helper_linux.cc:146: // TODO(vitalybuka) : why does it work only with ...
4 years, 11 months ago (2015-12-30 01:53:48 UTC) #5
Vitaly Buka corp
lgtm https://codereview.chromium.org/1553643002/diff/60001/components/printing/renderer/print_web_view_helper_linux.cc File components/printing/renderer/print_web_view_helper_linux.cc (left): https://codereview.chromium.org/1553643002/diff/60001/components/printing/renderer/print_web_view_helper_linux.cc#oldcode146 components/printing/renderer/print_web_view_helper_linux.cc:146: // TODO(vitalybuka) : why does it work only ...
4 years, 11 months ago (2016-01-04 21:09:32 UTC) #7
Vitaly Buka (NO REVIEWS)
lgtm
4 years, 11 months ago (2016-01-04 21:12:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553643002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553643002/140001
4 years, 11 months ago (2016-01-14 20:06:44 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:140001)
4 years, 11 months ago (2016-01-14 21:06:15 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 22:03:22 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/8dc97779e959b954c4784eceeaee62b11ee909e4
Cr-Commit-Position: refs/heads/master@{#369539}

Powered by Google App Engine
This is Rietveld 408576698