Unify some platform-specific methods for PrintWebViewHelper.

Unify some platform-specific methods for PrintWebViewHelper.

On Linux/Android/Windows, use somewhat shared implementations of:
- CopyMetafileDataToSharedMem()
- PrintPagesInternal()
- RenderPreviewPage()

Committed: https://crrev.com/8dc97779e959b954c4784eceeaee62b11ee909e4
Cr-Commit-Position: refs/heads/master@{#369539}

[Lei Zhang, 2015-12-30 01:38:49]

Patchset #2 (id:20001) has been deleted

[Lei Zhang, 2015-12-30 01:41:06]

Patchset #1 (id:1) has been deleted

[Lei Zhang, 2015-12-30 01:52:23]

Patchset #1 (id:40001) has been deleted

[Lei Zhang, 2015-12-30 01:53:48]

thestig@chromium.org changed reviewers:
+ vitalybuka@chromium.org

[Lei Zhang, 2015-12-30 01:53:48]

https://codereview.chromium.org/1553643002/diff/60001/components/printing/ren...
File components/printing/renderer/print_web_view_helper_linux.cc (left):

https://codereview.chromium.org/1553643002/diff/60001/components/printing/ren...
components/printing/renderer/print_web_view_helper_linux.cc:146: //
TODO(vitalybuka) : why does it work only with 1.25?
Because 1.25 is the WK scaling factor.

[Vitaly Buka corp, 2016-01-04 21:09:31]

vitalybuka@google.com changed reviewers:
+ vitalybuka@google.com

[Vitaly Buka corp, 2016-01-04 21:09:32]

lgtm

https://codereview.chromium.org/1553643002/diff/60001/components/printing/ren...
File components/printing/renderer/print_web_view_helper_linux.cc (left):

https://codereview.chromium.org/1553643002/diff/60001/components/printing/ren...
components/printing/renderer/print_web_view_helper_linux.cc:146: //
TODO(vitalybuka) : why does it work only with 1.25?
On 2015/12/30 01:53:48, Lei Zhang wrote:
> Because 1.25 is the WK scaling factor.

Quite possible, but seems to simple to be true :-)

https://codereview.chromium.org/1553643002/diff/100001/components/printing/re...
File components/printing/renderer/print_web_view_helper.cc (right):

https://codereview.chromium.org/1553643002/diff/100001/components/printing/re...
components/printing/renderer/print_web_view_helper.cc:1232:
scoped_ptr<PdfMetafileSkia> draft_metafile;
I'd put empty line to separate page_params and draft_metafile initialization.

https://codereview.chromium.org/1553643002/diff/100001/components/printing/re...
components/printing/renderer/print_web_view_helper.cc:1244: if
(draft_metafile.get()) {
if (draft_metafile) {

https://codereview.chromium.org/1553643002/diff/100001/components/printing/re...
components/printing/renderer/print_web_view_helper.cc:1248:
DCHECK(!draft_metafile.get());
seems DCHECK is not very useful here

[Vitaly Buka (NO REVIEWS), 2016-01-04 21:12:59]

lgtm

[Lei Zhang, 2016-01-14 20:06:06]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-01-14 20:06:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
vitalybuka@google.com, vitalybuka@chromium.org
Link to the patchset: https://codereview.chromium.org/1553643002/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2016-01-14 20:06:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553643002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553643002/140001

[commit-bot: I haz the power, 2016-01-14 21:06:15]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2016-01-14 22:03:22]

Description was changed from

==========
Unify some platform-specific methods for PrintWebViewHelper.

On Linux/Android/Windows, use somewhat shared implementations of:
- CopyMetafileDataToSharedMem()
- PrintPagesInternal()
- RenderPreviewPage()
==========

to

==========
Unify some platform-specific methods for PrintWebViewHelper.

On Linux/Android/Windows, use somewhat shared implementations of:
- CopyMetafileDataToSharedMem()
- PrintPagesInternal()
- RenderPreviewPage()

Committed: https://crrev.com/8dc97779e959b954c4784eceeaee62b11ee909e4
Cr-Commit-Position: refs/heads/master@{#369539}
==========

[commit-bot: I haz the power, 2016-01-14 22:03:22]

Patchset 5 (id:??) landed as
https://crrev.com/8dc97779e959b954c4784eceeaee62b11ee909e4
Cr-Commit-Position: refs/heads/master@{#369539}