Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: chromecast/crash/linux/crash_testing_utils.cc

Issue 1553503002: Convert Pass()→std::move() in //chromecast (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/crash/linux/crash_testing_utils.cc
diff --git a/chromecast/crash/linux/crash_testing_utils.cc b/chromecast/crash/linux/crash_testing_utils.cc
index 3ac61f716c922fdd83bda112ae65d981ab6242b2..d9edbc667d202fd1d555d63fbf3d1005921af678 100644
--- a/chromecast/crash/linux/crash_testing_utils.cc
+++ b/chromecast/crash/linux/crash_testing_utils.cc
@@ -4,6 +4,8 @@
#include "chromecast/crash/linux/crash_testing_utils.h"
+#include <utility>
+
#include "base/files/file_util.h"
#include "base/strings/string_split.h"
#include "base/strings/stringprintf.h"
@@ -45,7 +47,7 @@ scoped_ptr<base::ListValue> ParseLockFile(const std::string& path) {
scoped_ptr<base::Value> dump_info = DeserializeFromJson(line);
DumpInfo info(dump_info.get());
RCHECK(info.valid(), nullptr, "Invalid DumpInfo");
- dumps->Append(dump_info.Pass());
+ dumps->Append(std::move(dump_info));
}
return dumps;
@@ -94,7 +96,7 @@ bool FetchDumps(const std::string& lockfile_path,
for (base::Value* elem : *dump_list) {
scoped_ptr<DumpInfo> dump = make_scoped_ptr(new DumpInfo(elem));
RCHECK(dump->valid(), false, "Invalid DumpInfo");
- dumps->push_back(dump.Pass());
+ dumps->push_back(std::move(dump));
}
return true;
« no previous file with comments | « chromecast/common/media/shared_memory_chunk.cc ('k') | chromecast/crash/linux/synchronized_minidump_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698