Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: chromecast/crash/linux/synchronized_minidump_manager.cc

Issue 1553503002: Convert Pass()→std::move() in //chromecast (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/crash/linux/synchronized_minidump_manager.cc
diff --git a/chromecast/crash/linux/synchronized_minidump_manager.cc b/chromecast/crash/linux/synchronized_minidump_manager.cc
index 5be81404c073032088ae2f7148ec10e3e83db703..5af934c2b526ee0f2d479bfa5fe5bbff34f6168c 100644
--- a/chromecast/crash/linux/synchronized_minidump_manager.cc
+++ b/chromecast/crash/linux/synchronized_minidump_manager.cc
@@ -15,6 +15,7 @@
#include <sys/types.h>
#include <time.h>
#include <unistd.h>
+#include <utility>
#include "base/files/dir_reader_posix.h"
#include "base/files/file_util.h"
@@ -270,15 +271,15 @@ int SynchronizedMinidumpManager::ParseFiles() {
scoped_ptr<base::Value> dump_info = DeserializeFromJson(line);
DumpInfo info(dump_info.get());
RCHECK(info.valid(), -1);
- dumps->Append(dump_info.Pass());
+ dumps->Append(std::move(dump_info));
}
scoped_ptr<base::Value> metadata =
DeserializeJsonFromFile(base::FilePath(metadata_path_));
RCHECK(ValidateMetadata(metadata.get()), -1);
- dumps_ = dumps.Pass();
- metadata_ = metadata.Pass();
+ dumps_ = std::move(dumps);
+ metadata_ = std::move(metadata);
return 0;
}
@@ -363,7 +364,7 @@ ScopedVector<DumpInfo> SynchronizedMinidumpManager::GetDumps() {
dumps.push_back(new DumpInfo(elem));
}
- return dumps.Pass();
+ return dumps;
}
int SynchronizedMinidumpManager::SetCurrentDumps(
« no previous file with comments | « chromecast/crash/linux/crash_testing_utils.cc ('k') | chromecast/crash/linux/synchronized_minidump_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698