Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1553503002: Convert Pass()→std::move() in //chromecast (Closed)

Created:
4 years, 12 months ago by dcheng
Modified:
4 years, 12 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, eme-reviews_chromium.org, feature-media-reviews_chromium.org, gunsch+watch_chromium.org, halliwell+watch_chromium.org, kalyank, lcwu+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //chromecast (╯^□^)╯︵ ❄☃❄ BUG=557422 R=avi@chromium.org TBR=lcwu@chromium.org Committed: https://crrev.com/298775f0842a38fb2d3d456d055d9c0599cc50de Cr-Commit-Position: refs/heads/master@{#367044}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -168 lines) Patch
M chromecast/base/device_capabilities_impl.cc View 7 chunks +8 lines, -7 lines 0 comments Download
M chromecast/base/device_capabilities_impl_unittest.cc View 7 chunks +9 lines, -8 lines 0 comments Download
M chromecast/base/serializers.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromecast/browser/cast_browser_process.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chromecast/browser/cast_net_log.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chromecast/browser/media/media_pipeline_host.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chromecast/browser/metrics/cast_metrics_service_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromecast/browser/pref_service_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/url_request_context_factory.cc View 6 chunks +13 lines, -11 lines 0 comments Download
M chromecast/common/media/shared_memory_chunk.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M chromecast/crash/linux/crash_testing_utils.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chromecast/crash/linux/synchronized_minidump_manager.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chromecast/crash/linux/synchronized_minidump_manager_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chromecast/media/audio/cast_audio_output_stream_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chromecast/media/cdm/browser_cdm_cast.cc View 8 chunks +19 lines, -21 lines 0 comments Download
M chromecast/media/cma/base/buffering_frame_provider.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chromecast/media/cma/base/buffering_frame_provider_unittest.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M chromecast/media/cma/base/decoder_buffer_base.h View 2 chunks +2 lines, -1 line 0 comments Download
M chromecast/media/cma/decoder/cast_audio_decoder_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromecast/media/cma/ipc/media_message.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M chromecast/media/cma/ipc/media_message_fifo.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chromecast/media/cma/ipc_streamer/av_streamer_unittest.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M chromecast/media/cma/ipc_streamer/coded_frame_provider_host.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chromecast/media/cma/ipc_streamer/decoder_buffer_base_marshaller.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M chromecast/media/cma/pipeline/audio_pipeline_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chromecast/media/cma/pipeline/audio_video_pipeline_impl_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromecast/media/cma/pipeline/av_pipeline_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chromecast/media/cma/pipeline/media_pipeline_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chromecast/media/cma/pipeline/video_pipeline_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chromecast/media/cma/test/frame_generator_for_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chromecast/net/connectivity_checker_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/renderer/media/audio_pipeline_proxy.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chromecast/renderer/media/chromecast_media_renderer_factory.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chromecast/renderer/media/cma_renderer.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M chromecast/renderer/media/media_channel_proxy.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chromecast/renderer/media/media_pipeline_proxy.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chromecast/renderer/media/video_pipeline_proxy.cc View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dcheng
+avi for general review / sanity check +lcwu for OWNERS review
4 years, 12 months ago (2015-12-29 00:10:56 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553503002/1
4 years, 12 months ago (2015-12-29 00:11:33 UTC) #3
halliwell
On 2015/12/29 00:11:33, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 12 months ago (2015-12-29 00:22:28 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-29 00:45:08 UTC) #6
Avi (use Gerrit)
lgtm stampity stamp
4 years, 12 months ago (2015-12-29 03:04:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553503002/1
4 years, 12 months ago (2015-12-29 03:06:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-29 03:11:06 UTC) #10
commit-bot: I haz the power
4 years, 12 months ago (2015-12-29 03:11:59 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/298775f0842a38fb2d3d456d055d9c0599cc50de
Cr-Commit-Position: refs/heads/master@{#367044}

Powered by Google App Engine
This is Rietveld 408576698