Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Issue 1553453004: Use device-independent text for nvprmsaa4/16 in nanobench and dm (Closed)

Created:
4 years, 11 months ago by Kimmo Kinnunen
Modified:
4 years, 11 months ago
Reviewers:
mtklein, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use device-independent text for nvprmsaa4/16 in nanobench and dm Use device-independent text rendering in nanobench and dm when using configs nvprmsaa4 or nvprmsaa16. This was turned on for dm in commit: "Re-enable nvpr text rendering in DM" https://codereview.chromium.org/1306733007 This regressed in commit: "Add config options to run different GPU APIs to dm and nanobench" https://codereview.chromium.org/1490113005/ BUG=skia:2992 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1553453004 Committed: https://skia.googlesource.com/skia/+/e3c2f80006e766eb7e99bc64911243346b3ac6d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M tests/TestConfigParsing.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M tools/flags/SkCommonFlagsConfig.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553453004/1
4 years, 11 months ago (2015-12-29 08:41:01 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 11 months ago (2015-12-29 08:41:03 UTC) #4
Kimmo Kinnunen
4 years, 11 months ago (2015-12-29 08:41:28 UTC) #6
Chris Dalton
On 2015/12/29 08:41:28, Kimmo Kinnunen wrote: Just curious if we might be able to have ...
4 years, 11 months ago (2015-12-29 08:44:04 UTC) #7
Kimmo Kinnunen
On 2015/12/29 08:44:04, Chris Dalton wrote: > On 2015/12/29 08:41:28, Kimmo Kinnunen wrote: > > ...
4 years, 11 months ago (2015-12-29 08:46:33 UTC) #8
commit-bot: I haz the power
Dry run: No LGTM from a valid reviewer yet. Please ask for an LGTM from ...
4 years, 11 months ago (2015-12-29 14:41:06 UTC) #10
mtklein
lgtm
4 years, 11 months ago (2015-12-29 16:56:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1553453004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1553453004/1
4 years, 11 months ago (2015-12-29 16:56:40 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 16:57:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e3c2f80006e766eb7e99bc64911243346b3ac6d0

Powered by Google App Engine
This is Rietveld 408576698